You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Pavel Afremov (JIRA)" <ji...@apache.org> on 2007/02/22 14:12:05 UTC

[jira] Created: (HARMONY-3232) [drlvm][winx64] Add port atomic functions support for Windows x86_64 platform.

[drlvm][winx64] Add port atomic functions support for Windows x86_64 platform.
------------------------------------------------------------------------------

                 Key: HARMONY-3232
                 URL: https://issues.apache.org/jira/browse/HARMONY-3232
             Project: Harmony
          Issue Type: New Feature
            Reporter: Pavel Afremov


Patch adds port atomic functions support for Windows x86_64 platform.
•	port_atomic_cas16 and port_atomic_cas64 are defined via _InterlockedCompareExchange intrinsics
•	port_atomic_cas8 was defined in asm file, because C compiler for Windows x86_64 doesn't support inline assembler.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-3232) [drlvm][winx64] Add port atomic functions support for Windows x86_64 platform.

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky reassigned HARMONY-3232:
------------------------------------------

    Assignee: Gregory Shimansky

> [drlvm][winx64] Add port atomic functions support for Windows x86_64 platform.
> ------------------------------------------------------------------------------
>
>                 Key: HARMONY-3232
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3232
>             Project: Harmony
>          Issue Type: New Feature
>            Reporter: Pavel Afremov
>         Assigned To: Gregory Shimansky
>         Attachments: Add-port-atomic-functions-support-for-Windows-x86_64-platform.patch
>
>
> Patch adds port atomic functions support for Windows x86_64 platform.
> •	port_atomic_cas16 and port_atomic_cas64 are defined via _InterlockedCompareExchange intrinsics
> •	port_atomic_cas8 was defined in asm file, because C compiler for Windows x86_64 doesn't support inline assembler.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3232) [drlvm][winx64] Add port atomic functions support for Windows x86_64 platform.

Posted by "Pavel Afremov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Afremov updated HARMONY-3232:
-----------------------------------

    Attachment: Add-port-atomic-functions-support-for-Windows-x86_64-platform.patch

Untested patch

> [drlvm][winx64] Add port atomic functions support for Windows x86_64 platform.
> ------------------------------------------------------------------------------
>
>                 Key: HARMONY-3232
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3232
>             Project: Harmony
>          Issue Type: New Feature
>            Reporter: Pavel Afremov
>         Attachments: Add-port-atomic-functions-support-for-Windows-x86_64-platform.patch
>
>
> Patch adds port atomic functions support for Windows x86_64 platform.
> •	port_atomic_cas16 and port_atomic_cas64 are defined via _InterlockedCompareExchange intrinsics
> •	port_atomic_cas8 was defined in asm file, because C compiler for Windows x86_64 doesn't support inline assembler.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-3232) [drlvm][winx64] Add port atomic functions support for Windows x86_64 platform.

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky closed HARMONY-3232.
--------------------------------------


No response, assuming ok.

> [drlvm][winx64] Add port atomic functions support for Windows x86_64 platform.
> ------------------------------------------------------------------------------
>
>                 Key: HARMONY-3232
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3232
>             Project: Harmony
>          Issue Type: New Feature
>            Reporter: Pavel Afremov
>            Assignee: Gregory Shimansky
>         Attachments: Add-port-atomic-functions-support-for-Windows-x86_64-platform.patch
>
>
> Patch adds port atomic functions support for Windows x86_64 platform.
> •	port_atomic_cas16 and port_atomic_cas64 are defined via _InterlockedCompareExchange intrinsics
> •	port_atomic_cas8 was defined in asm file, because C compiler for Windows x86_64 doesn't support inline assembler.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-3232) [drlvm][winx64] Add port atomic functions support for Windows x86_64 platform.

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky resolved HARMONY-3232.
----------------------------------------

    Resolution: Fixed

Patch applied at 510539. I've made the following modification to the patch:

1. In the header I added inline bodies to the already present function declarations, corrected arguments conversion to satisfy the compiler and added INLINE modifier.
2. Removed functions code from port_atomic.c.
3. Renamed asm file to port_atomic_em64t.asm and put it in the same directory as port_atomic.c
4. Changed build rules to make asm.fileset to be non-empty on platforms other than windows x86_64

> [drlvm][winx64] Add port atomic functions support for Windows x86_64 platform.
> ------------------------------------------------------------------------------
>
>                 Key: HARMONY-3232
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3232
>             Project: Harmony
>          Issue Type: New Feature
>            Reporter: Pavel Afremov
>         Attachments: Add-port-atomic-functions-support-for-Windows-x86_64-platform.patch
>
>
> Patch adds port atomic functions support for Windows x86_64 platform.
> •	port_atomic_cas16 and port_atomic_cas64 are defined via _InterlockedCompareExchange intrinsics
> •	port_atomic_cas8 was defined in asm file, because C compiler for Windows x86_64 doesn't support inline assembler.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.