You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/08/13 16:04:12 UTC
[GitHub] [hadoop-ozone] dshavkanihort opened a new pull request #1327: HDDS-4098. Improve om admin getserviceroles error message
dshavkanihort opened a new pull request #1327:
URL: https://github.com/apache/hadoop-ozone/pull/1327
## What changes were proposed in this pull request?
Improve the Error Messages in Display.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4098?filter=-1
## How was this patch tested?
$ cd hadoop-ozone/dist/target/ozone-*/compose/ozone
$ docker-compose up -d
$ docker-compose exec scm bash
bash-4.2$ ozone admin om getserviceroles --service-id=om
Error: This command works only on OzoneManager HA cluster. Service ID specified does not match with ozone.om.service.ids defined in the configuration. Configured ozone.om.service.ids are
[]
bash-4.2$
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] github-actions[bot] closed pull request #1327: HDDS-4098. Improve om admin getserviceroles error message
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1327:
URL: https://github.com/apache/hadoop-ozone/pull/1327
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] github-actions[bot] commented on pull request #1327: HDDS-4098. Improve om admin getserviceroles error message
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1327:
URL: https://github.com/apache/hadoop-ozone/pull/1327#issuecomment-716905708
Thank you very much for the patch. I am closing this PR __temporarily__ as there was no activity recently and it is waiting for response from its author.
It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.
It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.
If you need ANY help to finish this PR, please [contact the community](https://github.com/apache/hadoop-ozone#contact) on the mailing list or the slack channel."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1327: HDDS-4098. Improve om admin getserviceroles error message
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1327:
URL: https://github.com/apache/hadoop-ozone/pull/1327#issuecomment-703643969
/pending
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] dineshchitlangia commented on pull request #1327: HDDS-4098. Improve om admin getserviceroles error message
Posted by GitBox <gi...@apache.org>.
dineshchitlangia commented on pull request #1327:
URL: https://github.com/apache/hadoop-ozone/pull/1327#issuecomment-673723932
@dshavkanihort Thank you for working on this.
Overall the changes look good to me, I see a checkstyle issue has been reported that needs to be fixed.
@adoroszlai do you have any suggestion for improving the wording of the message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1327: HDDS-4098. Improve om admin getserviceroles error message
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1327:
URL: https://github.com/apache/hadoop-ozone/pull/1327#issuecomment-687171426
Thanks @dshavkanihort for working on this.
The checkstyle issue @dineshchitlangia mentioned is that line 83 exceeds maximum allowed length of 80 characters:
https://github.com/apache/hadoop-ozone/blob/773af08368d339a75703caef42f74d9ab8cf6bb2/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/om/OMAdmin.java#L83
You can find the problem in the _Summary of failures_ section after opening _Details_ of the failed _checkstyle_ check. Here is the direct link: https://github.com/apache/hadoop-ozone/pull/1327/checks?check_run_id=981251536#step:4:5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1327: HDDS-4098. Improve om admin getserviceroles error message
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1327:
URL: https://github.com/apache/hadoop-ozone/pull/1327#issuecomment-673605022
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1327?src=pr&el=h1) Report
> Merging [#1327](https://codecov.io/gh/apache/hadoop-ozone/pull/1327?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/9c2218047bf8cf13f9c52ad819c938d9ba964b81&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1327?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1327 +/- ##
============================================
- Coverage 74.41% 74.34% -0.08%
- Complexity 10301 10319 +18
============================================
Files 984 985 +1
Lines 50394 50534 +140
Branches 4914 4934 +20
============================================
+ Hits 37503 37568 +65
- Misses 10531 10602 +71
- Partials 2360 2364 +4
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1327?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...java/org/apache/hadoop/ozone/admin/om/OMAdmin.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1327/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL3Rvb2xzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvYWRtaW4vb20vT01BZG1pbi5qYXZh) | `38.09% <50.00%> (ø)` | `3.00 <0.00> (ø)` | |
| [...doop/ozone/om/exceptions/OMNotLeaderException.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1327/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL29tL2V4Y2VwdGlvbnMvT01Ob3RMZWFkZXJFeGNlcHRpb24uamF2YQ==) | `48.48% <0.00%> (-18.19%)` | `3.00% <0.00%> (-2.00%)` | |
| [...hdds/scm/container/common/helpers/ExcludeList.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1327/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zY20vY29udGFpbmVyL2NvbW1vbi9oZWxwZXJzL0V4Y2x1ZGVMaXN0LmphdmE=) | `86.95% <0.00%> (-13.05%)` | `19.00% <0.00%> (-3.00%)` | |
| [...e/hadoop/ozone/recon/tasks/OMDBUpdatesHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1327/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL3JlY29uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvcmVjb24vdGFza3MvT01EQlVwZGF0ZXNIYW5kbGVyLmphdmE=) | `60.93% <0.00%> (-9.66%)` | `9.00% <0.00%> (-8.00%)` | |
| [...ache/hadoop/ozone/om/codec/S3SecretValueCodec.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1327/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9jb2RlYy9TM1NlY3JldFZhbHVlQ29kZWMuamF2YQ==) | `90.90% <0.00%> (-9.10%)` | `3.00% <0.00%> (-1.00%)` | |
| [...va/org/apache/hadoop/hdds/utils/db/RDBMetrics.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1327/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy91dGlscy9kYi9SREJNZXRyaWNzLmphdmE=) | `92.85% <0.00%> (-7.15%)` | `14.00% <0.00%> (-1.00%)` | |
| [...p/ozone/security/OzoneDelegationTokenSelector.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1327/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL3NlY3VyaXR5L096b25lRGVsZWdhdGlvblRva2VuU2VsZWN0b3IuamF2YQ==) | `72.22% <0.00%> (-5.56%)` | `7.00% <0.00%> (-1.00%)` | |
| [.../transport/server/ratis/ContainerStateMachine.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1327/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvcmF0aXMvQ29udGFpbmVyU3RhdGVNYWNoaW5lLmphdmE=) | `71.07% <0.00%> (-5.39%)` | `62.00% <0.00%> (-4.00%)` | |
| [...ozone/container/ozoneimpl/ContainerController.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1327/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvb3pvbmVpbXBsL0NvbnRhaW5lckNvbnRyb2xsZXIuamF2YQ==) | `76.31% <0.00%> (-5.27%)` | `13.00% <0.00%> (-1.00%)` | |
| [.../apache/hadoop/ozone/protocolPB/OzonePBHelper.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1327/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL3Byb3RvY29sUEIvT3pvbmVQQkhlbHBlci5qYXZh) | `90.00% <0.00%> (-5.00%)` | `6.00% <0.00%> (-1.00%)` | |
| ... and [45 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1327/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1327?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1327?src=pr&el=footer). Last update [9c22180...773af08](https://codecov.io/gh/apache/hadoop-ozone/pull/1327?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org