You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/29 08:24:28 UTC

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #319: fix: ApisixRoute update operations is not effective

gxthrj commented on a change in pull request #319:
URL: https://github.com/apache/apisix-ingress-controller/pull/319#discussion_r603099761



##########
File path: test/e2e/ingress/resourcepushing.go
##########
@@ -99,14 +98,56 @@ spec:
 		err = s.EnsureNumApisixUpstreamsCreated(1)
 		assert.Nil(ginkgo.GinkgoT(), err, "Checking number of upstreams")
 
+		s.NewAPISIXClient().GET("/ip").WithHeader("Host", "httpbin.com").Expect().Status(http.StatusOK)
+
+		// update
+		apisixRoute = fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+  name: httpbin-route
+spec:
+  http:
+  - name: rule1

Review comment:
       should add cases : 
   the diff `name` in the same `ApisixRoute`.
   the same `name` in the diff `ApisixRoute`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org