You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by dhalperi <gi...@git.apache.org> on 2017/04/13 23:05:00 UTC

[GitHub] beam pull request #2531: [BEAM-1870] ByteKey: remove ByteString from public ...

GitHub user dhalperi opened a pull request:

    https://github.com/apache/beam/pull/2531

    [BEAM-1870] ByteKey: remove ByteString from public API, replace with ByteBuffer

    * BigtableIO: use ByteBuffer not ByteString
    * HBaseIO: replace ByteString with byte[]
    
    R: @iemejia @lukecwik 
    
    Isma�l for general thoughts and HBase
    Luke to sanity check use of ByteBuffers.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/beam bytekey-bigtable-hbase

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2531.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2531
    
----
commit 9922e38621b4ca21e760edc7d143a7114509a4d9
Author: Dan Halperin <dh...@google.com>
Date:   2017-04-13T22:27:57Z

    ByteKey: remove ByteString from public API, replace with ByteBuffer
    
    * BigtableIO: use ByteBuffer not ByteString
    * HBaseIO: replace ByteString with byte[]

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2531: [BEAM-1870] ByteKey: remove ByteString from public ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2531


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---