You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Akanksha-kedia (via GitHub)" <gi...@apache.org> on 2026/06/17 13:18:03 UTC
[PR] Remove deprecated FunctionRegistry methods and inline CalciteSqlParser OPTIONS helpers [pinot]
Akanksha-kedia opened a new pull request, #18789:
URL: https://github.com/apache/pinot/pull/18789
## Summary
- Drop `FunctionRegistry.containsFunction(String)` and `getFunctionInfo(String, int)` — both were marked `@Deprecated` with no callers outside the class
- Inline the three private `@Deprecated` helpers in `CalciteSqlParser` (`extractOptionsFromSql`, `removeOptionsFromSql`, `extractOptionsMap`) directly into `compileToSqlNodeAndOptions` and delete the dead methods; behaviour is unchanged
## Test plan
- [ ] Existing `CalciteSqlParserTest` and `FunctionRegistryTest` pass — no API surface was removed that had external callers
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Remove deprecated FunctionRegistry methods and inline CalciteSqlParser OPTIONS helpers [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on PR #18789:
URL: https://github.com/apache/pinot/pull/18789#issuecomment-4764679488
Hey @xiangfu0, would appreciate a review on this when you get a chance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Remove deprecated FunctionRegistry methods and inline CalciteSqlParser OPTIONS helpers [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on PR #18789:
URL: https://github.com/apache/pinot/pull/18789#issuecomment-4741595614
@xiangfu0 @Jackie-Jiang all CI checks pass, review comments addressed. Please review when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Remove deprecated FunctionRegistry methods and inline CalciteSqlParser OPTIONS helpers [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on code in PR #18789:
URL: https://github.com/apache/pinot/pull/18789#discussion_r3435947377
##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##########
@@ -204,15 +204,6 @@ public static boolean contains(String canonicalName) {
return FUNCTION_MAP.containsKey(canonicalName);
}
- /**
- * @deprecated For performance concern, use {@link #contains(String)} instead to avoid invoking
- * {@link #canonicalize(String)} multiple times.
- */
- @Deprecated
- public static boolean containsFunction(String name) {
Review Comment:
Done — `containsFunction(String)` and `getFunctionInfo(String, int)` restored as delegating shims in the latest commit. PR now only contains the CalciteSqlParser inlining (private methods, no binary-compat impact).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Remove deprecated FunctionRegistry methods and inline CalciteSqlParser OPTIONS helpers [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia closed pull request #18789: Remove deprecated FunctionRegistry methods and inline CalciteSqlParser OPTIONS helpers
URL: https://github.com/apache/pinot/pull/18789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Remove deprecated FunctionRegistry methods and inline CalciteSqlParser OPTIONS helpers [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18789:
URL: https://github.com/apache/pinot/pull/18789#issuecomment-4732009800
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/18789?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `85.71429%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 64.77%. Comparing base ([`6464736`](https://app.codecov.io/gh/apache/pinot/commit/6464736bc35080edf2f171f190005693db0969d5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ef5c6ba`](https://app.codecov.io/gh/apache/pinot/commit/ef5c6baf944f2e5d6fe363ccec9288e2193b6efc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/18789?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://app.codecov.io/gh/apache/pinot/pull/18789?src=pr&el=tree&filepath=pinot-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fsql%2Fparsers%2FCalciteSqlParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | 85.71% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pinot/pull/18789?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18789 +/- ##
============================================
- Coverage 64.78% 64.77% -0.01%
+ Complexity 1309 1303 -6
============================================
Files 3380 3380
Lines 209540 209623 +83
Branches 32797 32822 +25
============================================
+ Hits 135751 135793 +42
- Misses 62863 62896 +33
- Partials 10926 10934 +8
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/18789/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/18789/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/18789/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/18789/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/18789/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/18789/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.77% <85.71%> (-0.01%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/18789/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.77% <85.71%> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/18789/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.77% <85.71%> (-0.01%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/18789/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.96% <85.71%> (-0.02%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/18789/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.25% <85.71%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/18789?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Remove deprecated FunctionRegistry methods and inline CalciteSqlParser OPTIONS helpers [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #18789:
URL: https://github.com/apache/pinot/pull/18789#discussion_r3431434284
##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##########
@@ -204,15 +204,6 @@ public static boolean contains(String canonicalName) {
return FUNCTION_MAP.containsKey(canonicalName);
}
- /**
- * @deprecated For performance concern, use {@link #contains(String)} instead to avoid invoking
- * {@link #canonicalize(String)} multiple times.
- */
- @Deprecated
- public static boolean containsFunction(String name) {
Review Comment:
Removing the deprecated `containsFunction(String)` / `getFunctionInfo(String,int)` wrappers is still a binary-incompatible change for callers compiled against released `pinot-common` jars. Upgraders that still invoke those entry points will start failing with `NoSuchMethodError`, so Pinot usually needs to keep the old methods as delegating shims until there is an explicit compatibility-removal plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Remove deprecated FunctionRegistry methods and inline CalciteSqlParser OPTIONS helpers [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on PR #18789:
URL: https://github.com/apache/pinot/pull/18789#issuecomment-4767186778
Closing based on reviewer feedback. Thank you @xiangfu0 and @Jackie-Jiang for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Remove deprecated FunctionRegistry methods and inline CalciteSqlParser OPTIONS helpers [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on PR #18789:
URL: https://github.com/apache/pinot/pull/18789#issuecomment-4730636021
@xiangfu0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Remove deprecated FunctionRegistry methods and inline CalciteSqlParser OPTIONS helpers [pinot]
Posted by "Akanksha-kedia (via GitHub)" <gi...@apache.org>.
Akanksha-kedia commented on code in PR #18789:
URL: https://github.com/apache/pinot/pull/18789#discussion_r3435447785
##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##########
@@ -204,15 +204,6 @@ public static boolean contains(String canonicalName) {
return FUNCTION_MAP.containsKey(canonicalName);
}
- /**
- * @deprecated For performance concern, use {@link #contains(String)} instead to avoid invoking
- * {@link #canonicalize(String)} multiple times.
- */
- @Deprecated
- public static boolean containsFunction(String name) {
Review Comment:
Good point, thank you. I'll restore `containsFunction(String)` and `getFunctionInfo(String,int)` as delegating shims so callers compiled against released jars don't get `NoSuchMethodError`. The CalciteSqlParser inlining (private methods only) should remain unaffected — will update this PR shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org