You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2013/01/23 22:39:13 UTC

[jira] [Commented] (NET-382) Subclasses of SocketClient should use _input_ and _output_ rather than calling _socket_.getInputStream() etc

    [ https://issues.apache.org/jira/browse/NET-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561113#comment-13561113 ] 

Sebb commented on NET-382:
--------------------------

Ageed, for safety, the _socket_, _input_ and _output_ fields ought to be made private. 

However that would break binary compatibility so would have to be done as part of a major version release.
This requires package name and Maven coordinate changes.
                
> Subclasses of SocketClient should use _input_ and _output_ rather than calling _socket_.getInputStream() etc
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: NET-382
>                 URL: https://issues.apache.org/jira/browse/NET-382
>             Project: Commons Net
>          Issue Type: Improvement
>            Reporter: Sebb
>         Attachments: sockclient-socket-private.diff
>
>
> SocketClient._connectAction() sets up \_input\_ and \_output\_ from \_socket\_ so it is wasteful to do this again in subclasses.
> Potentially consider making \_socket\_ private?
> However, this would currently break most of the "S" versions of the protocols, unless SocketClient is extended to handle their needs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira