You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2021/01/03 01:11:36 UTC
[GitHub] [royale-asjs] stanislaw89 opened a new pull request #1028: Better error reporting for Vertical/HorizontalLayout
stanislaw89 opened a new pull request #1028:
URL: https://github.com/apache/royale-asjs/pull/1028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #1028: Better error reporting for Vertical/HorizontalLayout
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #1028:
URL: https://github.com/apache/royale-asjs/pull/1028#issuecomment-753596234
FWIW, `org.apache.royale.debugging.assert` is probably better for this kind of error reporting because it's stripped out in the production version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #1028: Better error reporting for Vertical/HorizontalLayout
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #1028:
URL: https://github.com/apache/royale-asjs/pull/1028#issuecomment-753665450
How's this?
https://github.com/apache/royale-asjs/commit/dedc8d237a62bfe19598bb0370930f4b7971c960
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] carlosrovira commented on pull request #1028: Better error reporting for Vertical/HorizontalLayout
Posted by GitBox <gi...@apache.org>.
carlosrovira commented on pull request #1028:
URL: https://github.com/apache/royale-asjs/pull/1028#issuecomment-753685345
yeah, we can assume that the developer reach production with a right value, so I think it's ok.
I was trying to figure if that initial if was needed. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] carlosrovira commented on pull request #1028: Better error reporting for Vertical/HorizontalLayout
Posted by GitBox <gi...@apache.org>.
carlosrovira commented on pull request #1028:
URL: https://github.com/apache/royale-asjs/pull/1028#issuecomment-753601410
Thanks Harbs! I wasn't aware of that, will take a look and see how to adapt Jewel to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #1028: Better error reporting for Vertical/HorizontalLayout
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #1028:
URL: https://github.com/apache/royale-asjs/pull/1028#issuecomment-753665577
Not sure if the check is needed for production as well. I was assuming not.
If yes, you should keep the `if` but drop the `else`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] carlosrovira commented on pull request #1028: Better error reporting for Vertical/HorizontalLayout
Posted by GitBox <gi...@apache.org>.
carlosrovira commented on pull request #1028:
URL: https://github.com/apache/royale-asjs/pull/1028#issuecomment-753663790
Hi Harbs,
I'm looking for a way to rewrite the `setGap` with assert and don't find a way that like me. Can you suggest one?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #1028: Better error reporting for Vertical/HorizontalLayout
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #1028:
URL: https://github.com/apache/royale-asjs/pull/1028#issuecomment-753617567
Here's an example of its use:
https://github.com/apache/royale-asjs/blob/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/routing/RouteToState.as#L111
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] carlosrovira merged pull request #1028: Better error reporting for Vertical/HorizontalLayout
Posted by GitBox <gi...@apache.org>.
carlosrovira merged pull request #1028:
URL: https://github.com/apache/royale-asjs/pull/1028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org