You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/05/03 21:09:20 UTC
Review Request 70596: Launched tasks with more memory in SLRP unit
tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70596/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jan Schlicht.
Bugs: MESOS-9765
https://issues.apache.org/jira/browse/MESOS-9765
Repository: mesos
Description
-------
Raised the task memory to 128MB (which are the value used in most persistent
volume tests) in all SLRP tests that launch tasks to avoid OOM.
Diffs
-----
src/tests/storage_local_resource_provider_tests.cpp ec2222d7aeef1cb3d1a5b4b3419dfd912d41a8c6
Diff: https://reviews.apache.org/r/70596/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70596: Launched tasks with more memory in SLRP
unit tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70596/#review215049
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70596]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 3, 2019, 9:09 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70596/
> -----------------------------------------------------------
>
> (Updated May 3, 2019, 9:09 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-9765
> https://issues.apache.org/jira/browse/MESOS-9765
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Raised the task memory to 128MB (which are the value used in most persistent
> volume tests) in all SLRP tests that launch tasks to avoid OOM.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp ec2222d7aeef1cb3d1a5b4b3419dfd912d41a8c6
>
>
> Diff: https://reviews.apache.org/r/70596/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70596: Launched tasks with more memory in SLRP
unit tests.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On May 6, 2019, 11:55 a.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Line 1795 (original), 1795 (patched)
> > <https://reviews.apache.org/r/70596/diff/1/?file=2142847#file2142847line1795>
> >
> > Could we move this into a test class-specific constant?
> >
> > Here and below.
Made this a function that takes `persistentVolumes` as additional resources and adds cpus and mem to them.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70596/#review215058
-----------------------------------------------------------
On May 3, 2019, 9:09 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70596/
> -----------------------------------------------------------
>
> (Updated May 3, 2019, 9:09 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-9765
> https://issues.apache.org/jira/browse/MESOS-9765
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Raised the task memory to 128MB (which are the value used in most persistent
> volume tests) in all SLRP tests that launch tasks to avoid OOM.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp ec2222d7aeef1cb3d1a5b4b3419dfd912d41a8c6
>
>
> Diff: https://reviews.apache.org/r/70596/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70596: Launched tasks with more memory in SLRP
unit tests.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70596/#review215058
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
src/tests/storage_local_resource_provider_tests.cpp
Line 1 (original), 1 (patched)
<https://reviews.apache.org/r/70596/#comment301442>
Please make sure your commit message passes the linter (e.g., needs to be wrapped at 72 chars).
src/tests/storage_local_resource_provider_tests.cpp
Line 1795 (original), 1795 (patched)
<https://reviews.apache.org/r/70596/#comment301444>
Could we move this into a test class-specific constant?
Here and below.
- Benjamin Bannier
On May 3, 2019, 11:09 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70596/
> -----------------------------------------------------------
>
> (Updated May 3, 2019, 11:09 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
>
>
> Bugs: MESOS-9765
> https://issues.apache.org/jira/browse/MESOS-9765
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Raised the task memory to 128MB (which are the value used in most persistent
> volume tests) in all SLRP tests that launch tasks to avoid OOM.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp ec2222d7aeef1cb3d1a5b4b3419dfd912d41a8c6
>
>
> Diff: https://reviews.apache.org/r/70596/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>