You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/08/04 18:27:55 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #37026: MINOR: [Go] Add gRPC status details to sample Flight SQL server
lidavidm opened a new pull request, #37026:
URL: https://github.com/apache/arrow/pull/37026
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Needed to test apache-arrow#963.
### What changes are included in this PR?
Have the SQLite Flight SQL server sample emit a gRPC status detail.
### Are these changes tested?
No.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #37026: MINOR: [Go] Add gRPC status details to sample Flight SQL server
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #37026:
URL: https://github.com/apache/arrow/pull/37026#issuecomment-1669609849
Looks like lint issues are from a different commit, I'll merge here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #37026: MINOR: [Go] Add gRPC status details to sample Flight SQL server
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #37026:
URL: https://github.com/apache/arrow/pull/37026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37026: MINOR: [Go] Add gRPC status details to sample Flight SQL server
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37026:
URL: https://github.com/apache/arrow/pull/37026#issuecomment-1671851141
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit c6c21c0056675b5137fd902022c24980fac726b4.
There were 2 benchmark results indicating a performance regression:
- Commit Run on `arm64-m6g-linux-compute` at [2023-08-09 05:06:14Z](http://conbench.ursa.dev/compare/runs/cec26e121ec54f129ecd2d21d8d3b8c6...3f719c9cc6fb4a84ab61974c8f92d527/)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-16, scale_factor=10](http://conbench.ursa.dev/compare/benchmarks/064d319005ae74c38000a4b39959ba15...064d33a2702376dc800095fd924c8675)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-17, scale_factor=1](http://conbench.ursa.dev/compare/benchmarks/064d319324177e318000939d3e780baf...064d33a69e4073a38000c711e91f8b76)
The [full Conbench report](https://github.com/apache/arrow/runs/15757015705) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #37026: MINOR: [Go] Add gRPC status details to sample Flight SQL server
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #37026:
URL: https://github.com/apache/arrow/pull/37026#issuecomment-1668259540
Looks like gRPC error details are in practice useless since they're hardcoded to Google Cloud's error definition. I'll update this to also test arbitrary trailers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org