[jira] [Comment Edited] (DERBY-6516) Convert lang/nestedCommit.sql to JUnit NestedCommitTest

["Dag H. Wanvik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958753#comment-13958753 ] 

Dag H. Wanvik edited comment on DERBY-6516 at 4/3/14 12:13 PM:
---------------------------------------------------------------

The code that fails here is in GenericLanguageConnectionContext#setIsolationLevel:
{code:setIsolationLevel}
if (!verifyAllHeldResultSetsAreClosed())
{
    throw StandardException.newException(SQLState.LANG_CANT_CHANGE_ISOLATION_HOLD_CURSOR
}
{code}

and the method "verifyAllHeldResultSetsAreClosed" does explicit garbage collection:

{code:verifyAllHeldResultSetsAreClosed}
:
        // There may be open ResultSet's that are yet to be garbage collected
        // let's try and force these out rather than throw an error
        System.gc();
        System.runFinalization();
:
{code}

so it seems this is consistent with what we are seeing: intermittent errors.



was (Author: dagw):
The code that fails here is in GenericLanguageConnectionContext#setIsolationLevel:
{code:GenericLanguageConnectionContext#setIsolationLevel}
if (!verifyAllHeldResultSetsAreClosed())
{
    throw StandardException.newException(SQLState.LANG_CANT_CHANGE_ISOLATION_HOLD_CURSOR
}
{code}

and the method "verifyAllHeldResultSetsAreClosed" does explicit garbage collection:

{code:verifyAllHeldResultSetsAreClosed}
:
        // There may be open ResultSet's that are yet to be garbage collected
        // let's try and force these out rather than throw an error
        System.gc();
        System.runFinalization();
:
{code}

so it seems this is consistent with what we are seeing: intermittent errors.


> Convert lang/nestedCommit.sql to JUnit NestedCommitTest
> -------------------------------------------------------
>
>                 Key: DERBY-6516
>                 URL: https://issues.apache.org/jira/browse/DERBY-6516
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Minor
>             Fix For: 10.11.0.0
>
>         Attachments: DERBY-6516.diff, DERBY-6516.stat
>
>
> Uploading a patch to convert this test to JUnit; also wires into lang/_Suite and removed it from the harness tests.



--
This message was sent by Atlassian JIRA
(v6.2#6252)