[GitHub] [incubator-mxnet] piotrwolinski-intel commented on a change in pull request #20825: [master] Implemented oneDNN Backward Adaptive Pooling kernel

[GitBox <gi...@apache.org>]

piotrwolinski-intel commented on a change in pull request #20825:
URL: https://github.com/apache/incubator-mxnet/pull/20825#discussion_r805824553



##########
File path: src/operator/nn/dnnl/dnnl_pooling-inl.h
##########
@@ -28,10 +28,13 @@
 
 #include <dnnl.hpp>
 #include <utility>
+#include <vector>
 
 #include "../pooling-inl.h"
 #include "./dnnl_base-inl.h"
 
+#define DIV_ROUND_UP(a, b) (((a) + (b - 1)) / b)

Review comment:
       Not necessarily, changed for better readability. 

##########
File path: src/operator/contrib/adaptive_avg_pooling.cc
##########
@@ -25,11 +25,13 @@
 // #include "elemwise_op_common.h"
 #include "../elemwise_op_common.h"
 #if MXNET_USE_ONEDNN == 1
+#include "../nn/dnnl/dnnl_base-inl.h"
 #include "../nn/dnnl/dnnl_pooling-inl.h"
 #endif  // MXNET_USE_ONEDNN
 
 #define START_IND(a, b, c) static_cast<int>(std::floor(static_cast<float>(a * c) / b))
 #define END_IND(a, b, c)   static_cast<int>(std::ceil(static_cast<float>((a + 1) * c) / b))
+#define DIV_ROUND_UP(a, b) (((a) + (b - 1)) / b)

Review comment:
       Not necessarily, changed for better readability. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org