You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Mark Dalton <mw...@cray.com> on 2005/03/15 07:10:15 UTC

Review process/Votes option

I would like to know if subversion is capable of reviews, where code
commited would be 'held' until it was reviewed by at least 2 or 3 people.
This would be similar to the 'Votes' I saw mentioned in subversion 
'HACKING',
however, I don't find anything about 'votes' in the source or anywhere else.
And of course track which reviewers reviewed each change.

Does anyone have another similar review module/add-on?

Thankyou!

Mark

I saw a mention of 'Votes' in:
    ./www/cvs-changelog.html
    ./STATUS
    ./HACKING

Here's an example, probably as complex as an entry would ever get:

   * r98765 (issue #56789)
     Make commit editor take a closure object for future mindreading.
     Justification: API stability, as prep for future enhancement.
     Notes: There was consensus on the desirability of this feature in
       the near future; see thread at http://... (Message-Id: blahblah).
     Concerns: Vetoed by jerenkrantz due to privacy concerns with the
       implementation; see thread at http://... (Message-Id: blahblah)
     Votes:
       +1: ghudson, bliss
       +0: cmpilato
       -0: gstein
       -1: jerenkrantz

A change needs three +1 votes from full committers (or partial
committers for the involved areas), and no vetoes, to go into A.B.x.


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Review process/Votes option

Posted by "Ronny T. Lampert" <te...@uni.de>.
Hi,

> I would like to know if subversion is capable of reviews, where code
> commited would be 'held' until it was reviewed by at least 2 or 3 people.

http://www.rocklinux.net/svn.html -> submaster

Rock Linux did some extensions around it, with some kind of voting.
Must've mentioned in the FAQs somewhere, too?

Cheers,
Ronny

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org