You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Arnaud Heritier (JIRA)" <ji...@codehaus.org> on 2007/08/04 22:22:13 UTC

[jira] Created: (MINVOKER-7) Add groovy support for pre/post build hook scripts

Add groovy support for pre/post build hook scripts
--------------------------------------------------

                 Key: MINVOKER-7
                 URL: http://jira.codehaus.org/browse/MINVOKER-7
             Project: Maven 2.x Invoker Plugin
          Issue Type: New Feature
            Reporter: Arnaud Heritier
            Assignee: John Casey


I would like to be able to write those scripts in groovy instead of beanshell. I suppose that it is possible. We could reuse the code of the maven plugin to execute groovy scripts (groovy-maven-plugin @ mojo).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MINVOKER-7) Add groovy support for pre/post build hook scripts

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MINVOKER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=144074#action_144074 ] 

Olivier Lamy commented on MINVOKER-7:
-------------------------------------

+1.


> Add groovy support for pre/post build hook scripts
> --------------------------------------------------
>
>                 Key: MINVOKER-7
>                 URL: http://jira.codehaus.org/browse/MINVOKER-7
>             Project: Maven 2.x Invoker Plugin
>          Issue Type: New Feature
>            Reporter: Arnaud Heritier
>            Assignee: John Casey
>
> I would like to be able to write those scripts in groovy instead of beanshell. I suppose that it is possible. We could reuse the code of the maven plugin to execute groovy scripts (groovy-maven-plugin @ mojo).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MINVOKER-7) Add groovy support for pre/post build hook scripts

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MINVOKER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MINVOKER-7.
------------------------------------

         Assignee: Benjamin Bentmann  (was: John Casey)
       Resolution: Fixed
    Fix Version/s: 1.3

Done in [r683781|http://svn.apache.org/viewvc?view=rev&revision=683781], cheers!

> Add groovy support for pre/post build hook scripts
> --------------------------------------------------
>
>                 Key: MINVOKER-7
>                 URL: http://jira.codehaus.org/browse/MINVOKER-7
>             Project: Maven 2.x Invoker Plugin
>          Issue Type: New Feature
>    Affects Versions: 1.0
>            Reporter: Arnaud Heritier
>            Assignee: Benjamin Bentmann
>             Fix For: 1.3
>
>
> I would like to be able to write those scripts in groovy instead of beanshell. I suppose that it is possible. We could reuse the code of the maven plugin to execute groovy scripts (groovy-maven-plugin @ mojo).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MINVOKER-7) Add groovy support for pre/post build hook scripts

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MINVOKER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=134980#action_134980 ] 

Benjamin Bentmann commented on MINVOKER-7:
------------------------------------------

How would you expect the plugin to choose between the BeanShell and the Groovy interpreter (or some future thing) when processing scripts?

I could imagine a new mojo parameter "scriptLanguage" that could be set to "beanshell" or "groovy". Would be an explicit hint for the plugin but would limit all IT projects run during the same Invoker execution to use the same script language.

Alternatively, some smarter heuristic that simply derives the interpreter from the file extension of the configured pre-/post-build script. In addition, we could consider to extend the mojo parameters "preBuildHookScript" and "postBuildHookScript" to accept extension-less file names and have the plugin search for supported scripts types. For example
{code:xml}
<postBuildHookScript>verify</preBuildHookScript>
{code}
could mean to search for "verify", next for "verify.groovy" and finally for a "verify.bsh", where the first existing one will be picked up. This would allow to easily mix the usage of BeanShell and Groovy among the various IT projects. Thoughts?

> Add groovy support for pre/post build hook scripts
> --------------------------------------------------
>
>                 Key: MINVOKER-7
>                 URL: http://jira.codehaus.org/browse/MINVOKER-7
>             Project: Maven 2.x Invoker Plugin
>          Issue Type: New Feature
>            Reporter: Arnaud Heritier
>            Assignee: John Casey
>
> I would like to be able to write those scripts in groovy instead of beanshell. I suppose that it is possible. We could reuse the code of the maven plugin to execute groovy scripts (groovy-maven-plugin @ mojo).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MINVOKER-7) Add groovy support for pre/post build hook scripts

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MINVOKER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann updated MINVOKER-7:
-------------------------------------

    Affects Version/s: 1.0

> Add groovy support for pre/post build hook scripts
> --------------------------------------------------
>
>                 Key: MINVOKER-7
>                 URL: http://jira.codehaus.org/browse/MINVOKER-7
>             Project: Maven 2.x Invoker Plugin
>          Issue Type: New Feature
>    Affects Versions: 1.0
>            Reporter: Arnaud Heritier
>            Assignee: John Casey
>
> I would like to be able to write those scripts in groovy instead of beanshell. I suppose that it is possible. We could reuse the code of the maven plugin to execute groovy scripts (groovy-maven-plugin @ mojo).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MINVOKER-7) Add groovy support for pre/post build hook scripts

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MINVOKER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=144076#action_144076 ] 

Olivier Lamy commented on MINVOKER-7:
-------------------------------------

Oh yes sorry.
File extension way in order to mix groovy and bsh.
Some dev have preferences and we can admit this fact  :-).

> Add groovy support for pre/post build hook scripts
> --------------------------------------------------
>
>                 Key: MINVOKER-7
>                 URL: http://jira.codehaus.org/browse/MINVOKER-7
>             Project: Maven 2.x Invoker Plugin
>          Issue Type: New Feature
>            Reporter: Arnaud Heritier
>            Assignee: John Casey
>
> I would like to be able to write those scripts in groovy instead of beanshell. I suppose that it is possible. We could reuse the code of the maven plugin to execute groovy scripts (groovy-maven-plugin @ mojo).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MINVOKER-7) Add groovy support for pre/post build hook scripts

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MINVOKER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=148391#action_148391 ] 

Benjamin Bentmann commented on MINVOKER-7:
------------------------------------------

Additionally removed the file extension from the default hook script names in [r696825|http://svn.apache.org/viewvc?view=rev&revision=696825] to enable the interpreter detection by default.

> Add groovy support for pre/post build hook scripts
> --------------------------------------------------
>
>                 Key: MINVOKER-7
>                 URL: http://jira.codehaus.org/browse/MINVOKER-7
>             Project: Maven 2.x Invoker Plugin
>          Issue Type: New Feature
>    Affects Versions: 1.0
>            Reporter: Arnaud Heritier
>            Assignee: Benjamin Bentmann
>             Fix For: 1.3
>
>
> I would like to be able to write those scripts in groovy instead of beanshell. I suppose that it is possible. We could reuse the code of the maven plugin to execute groovy scripts (groovy-maven-plugin @ mojo).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MINVOKER-7) Add groovy support for pre/post build hook scripts

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MINVOKER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=144075#action_144075 ] 

Benjamin Bentmann commented on MINVOKER-7:
------------------------------------------

To which approach exactly do your refer, the file extension way?

> Add groovy support for pre/post build hook scripts
> --------------------------------------------------
>
>                 Key: MINVOKER-7
>                 URL: http://jira.codehaus.org/browse/MINVOKER-7
>             Project: Maven 2.x Invoker Plugin
>          Issue Type: New Feature
>            Reporter: Arnaud Heritier
>            Assignee: John Casey
>
> I would like to be able to write those scripts in groovy instead of beanshell. I suppose that it is possible. We could reuse the code of the maven plugin to execute groovy scripts (groovy-maven-plugin @ mojo).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira