You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by vinayshukla <gi...@git.apache.org> on 2016/12/15 08:14:45 UTC
[GitHub] zeppelin pull request #1767: ZEPPELIN-1817 - Added documentation to Zeppelin...
GitHub user vinayshukla opened a pull request:
https://github.com/apache/zeppelin/pull/1767
ZEPPELIN-1817 - Added documentation to Zeppelin's shiro.ini to provide help users configure security
### What is this PR for?
Add documentation to Zeppelin's shiro.ini to provide help users configure security
The added documentation walks through different security stages
### What type of PR is it?
Documentation
### Todos
* None
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1817,
### How should this be tested?
This pull request add only documentation, to see new doc, see shiro.ini.template
### Questions:
* Does the licenses files need update?
N
* Is there breaking changes for older versions?
N
* Does this needs documentation?
N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vinayshukla/zeppelin zeppelin-1817
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1767.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1767
----
commit e340ad2a9c60c3ae418002cee0a6875d3533d3f2
Author: Vinay Shukla <vi...@gmail.com>
Date: 2016-12-15T08:10:01Z
Added documentation to Zeppelin's shiro.ini to provide help users configure security
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1767
@vinayshukla Looks good \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...
Posted by qinchaofeng <gi...@git.apache.org>.
Github user qinchaofeng commented on the issue:
https://github.com/apache/zeppelin/pull/1767
@AhyoungRyu thinks, and the question is I set shiro.ini like this:
and set to property zeppelin.anonymous.allowed to true in conf/zeppelin-site.xml
I also need to login using username/password
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1767
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1767
Great improvement, thank you @vinayshukla !
But indeed, it would be really nice to have documentation available on the website as well, as @Leemoonsoo suggests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...
Posted by qinchaofeng <gi...@git.apache.org>.
Github user qinchaofeng commented on the issue:
https://github.com/apache/zeppelin/pull/1767
when I set to property zeppelin.anonymous.allowed to true in conf/zeppelin-site.xml and set cfg in the shiro like this:
I also need login using username/password
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1767
Thanks @vinayshukla for the contribution.
We have a document about configuring shiro authentication on [website](https://github.com/apache/zeppelin/blob/master/docs/security/shiroauthentication.md).
What do you think keeping information in the single document(website), instead of keeping two different document for the single feature?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...
Posted by vinayshukla <gi...@git.apache.org>.
Github user vinayshukla commented on the issue:
https://github.com/apache/zeppelin/pull/1767
@Leemoonsoo The CI failure is unrelated, the 2 files changed are template and markdown. Is there a way to re-trigger the CI?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1767: ZEPPELIN-1817 - Added documentation to Zeppelin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1767
---
[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1767
@qinchaofeng If you want to turn off shiro(login as `anonymous`), you should set `shiro.ini` like below
```
/** = anon
#/** = authc
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1767
@vinayshukla I think what @Leemoonsoo suggested was having only one documentation about this info.
And IMO having detailed information to describe about "Authentication in Zeppelin", but it's not good idea put this all contents under "Overview".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---