You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Herve Boutemy (JIRA)" <ji...@codehaus.org> on 2013/02/08 03:01:13 UTC
[jira] (WAGON-388) remove wagon-http-shared4 dependency on
httpclient
Herve Boutemy created WAGON-388:
-----------------------------------
Summary: remove wagon-http-shared4 dependency on httpclient
Key: WAGON-388
URL: https://jira.codehaus.org/browse/WAGON-388
Project: Maven Wagon
Issue Type: Improvement
Components: wagon-http, wagon-http-lightweight
Affects Versions: 2.0, 2.4
Reporter: Herve Boutemy
AbstractHttpClientWagon uses classes from [HttpClient|http://hc.apache.org/httpcomponents-client-ga/httpclient/index.html]
Lightweight wagon extends AbstractHttpClientWagon but uses JRE java.net classes
AbstractHttpClientWagon should not depend on httpclient: it can depend on [HttpCore|http://hc.apache.org/httpcomponents-core-ga/index.html], if useful to share some utilities between wagon-http and wagon-http-lightweight, but not HttpClient
Such separation, possible now that HttpComponents has 2 separate layers, will ease maintenance
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (WAGON-388) remove wagon-http-shared4 dependency on
httpclient
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/WAGON-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=318897#comment-318897 ]
Herve Boutemy commented on WAGON-388:
-------------------------------------
ok, so the solution is even simpler than expected: the abstract class is to move to wagon-http, and removed from wagon-http-shared4
(notice that previously, httpclient was excluded but not httpcore, which caused a useless dependency: see [dependency report|http://maven.apache.org/wagon-archives/wagon-2.2/wagon-providers/wagon-http-lightweight/dependencies.html])
> remove wagon-http-shared4 dependency on httpclient
> --------------------------------------------------
>
> Key: WAGON-388
> URL: https://jira.codehaus.org/browse/WAGON-388
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-http, wagon-http-lightweight
> Affects Versions: 2.0, 2.4
> Reporter: Herve Boutemy
>
> AbstractHttpClientWagon uses classes from [HttpClient|http://hc.apache.org/httpcomponents-client-ga/httpclient/index.html]
> Lightweight wagon extends AbstractHttpClientWagon but uses JRE java.net classes
> AbstractHttpClientWagon should not depend on httpclient: it can depend on [HttpCore|http://hc.apache.org/httpcomponents-core-ga/index.html], if useful to share some utilities between wagon-http and wagon-http-lightweight, but not HttpClient
> Such separation, possible now that HttpComponents has 2 separate layers, will ease maintenance
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (WAGON-388) remove wagon-http-shared4 dependency on
httpclient
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/WAGON-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319016#comment-319016 ]
Herve Boutemy commented on WAGON-388:
-------------------------------------
code removed from wagon-http-shared4 in [34e9c2a0|http://git-wip-us.apache.org/repos/asf/maven-wagon/commit/34e9c2a0] and wagon-http-shared in [24a54ebe|http://git-wip-us.apache.org/repos/asf/maven-wagon/commit/24a54ebe]
now we need to choose one HtmlFileListParser implementation and drop one of the 2 libraries, then update [the dependency map|http://maven.apache.org/wagon-archives/wagon-2.2/]
> remove wagon-http-shared4 dependency on httpclient
> --------------------------------------------------
>
> Key: WAGON-388
> URL: https://jira.codehaus.org/browse/WAGON-388
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-http, wagon-http-lightweight
> Affects Versions: 2.0, 2.4
> Reporter: Herve Boutemy
>
> AbstractHttpClientWagon uses classes from [HttpClient|http://hc.apache.org/httpcomponents-client-ga/httpclient/index.html]
> Lightweight wagon extends AbstractHttpClientWagon but uses JRE java.net classes
> AbstractHttpClientWagon should not depend on httpclient: it can depend on [HttpCore|http://hc.apache.org/httpcomponents-core-ga/index.html], if useful to share some utilities between wagon-http and wagon-http-lightweight, but not HttpClient
> Such separation, possible now that HttpComponents has 2 separate layers, will ease maintenance
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (WAGON-388) remove wagon-http-shared4 dependency on
httpclient
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/WAGON-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319017#comment-319017 ]
Olivier Lamy commented on WAGON-388:
------------------------------------
+1 for jsoup impl.
> remove wagon-http-shared4 dependency on httpclient
> --------------------------------------------------
>
> Key: WAGON-388
> URL: https://jira.codehaus.org/browse/WAGON-388
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-http, wagon-http-lightweight
> Affects Versions: 2.0, 2.4
> Reporter: Herve Boutemy
>
> AbstractHttpClientWagon uses classes from [HttpClient|http://hc.apache.org/httpcomponents-client-ga/httpclient/index.html]
> Lightweight wagon extends AbstractHttpClientWagon but uses JRE java.net classes
> AbstractHttpClientWagon should not depend on httpclient: it can depend on [HttpCore|http://hc.apache.org/httpcomponents-core-ga/index.html], if useful to share some utilities between wagon-http and wagon-http-lightweight, but not HttpClient
> Such separation, possible now that HttpComponents has 2 separate layers, will ease maintenance
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (WAGON-388) remove wagon-http-shared4 dependency on
httpclient
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/WAGON-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy closed WAGON-388.
-------------------------------
Resolution: Fixed
Fix Version/s: 2.5
Assignee: Herve Boutemy
ok, sone in [5fcc6315|http://git-wip-us.apache.org/repos/asf/maven-wagon/commit/5fcc6315]
doc updated in [f0ea14a8|http://git-wip-us.apache.org/repos/asf/maven-wagon/commit/f0ea14a8]
> remove wagon-http-shared4 dependency on httpclient
> --------------------------------------------------
>
> Key: WAGON-388
> URL: https://jira.codehaus.org/browse/WAGON-388
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-http, wagon-http-lightweight
> Affects Versions: 2.0, 2.4
> Reporter: Herve Boutemy
> Assignee: Herve Boutemy
> Fix For: 2.5
>
>
> AbstractHttpClientWagon uses classes from [HttpClient|http://hc.apache.org/httpcomponents-client-ga/httpclient/index.html]
> Lightweight wagon extends AbstractHttpClientWagon but uses JRE java.net classes
> AbstractHttpClientWagon should not depend on httpclient: it can depend on [HttpCore|http://hc.apache.org/httpcomponents-core-ga/index.html], if useful to share some utilities between wagon-http and wagon-http-lightweight, but not HttpClient
> Such separation, possible now that HttpComponents has 2 separate layers, will ease maintenance
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (WAGON-388) remove wagon-http-shared4 dependency on
httpclient
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/WAGON-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=318871#comment-318871 ]
Olivier Lamy commented on WAGON-388:
------------------------------------
Euh I miss you Hervé
{code}
public class LightweightHttpWagon
extends StreamWagon
{code}
see https://git-wip-us.apache.org/repos/asf?p=maven-wagon.git;a=blob;f=wagon-providers/wagon-http-lightweight/src/main/java/org/apache/maven/wagon/providers/http/LightweightHttpWagon.java;h=b15d059dbfd50d30af057be6ed17ec03f24963ef;hb=HEAD
wagon-http-lightweight depends on shared4 only for an utility class called HtmlFileListParser (maybe could be moved somewhere really a module with only this class ?)
And dependency on shared4 exclude httpclient deps
{code}
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>wagon-http-shared4</artifactId>
<version>${project.version}</version>
<exclusions>
<exclusion>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
</exclusion>
<exclusion>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
</exclusion>
</exclusions>
</dependency>
{code}
> remove wagon-http-shared4 dependency on httpclient
> --------------------------------------------------
>
> Key: WAGON-388
> URL: https://jira.codehaus.org/browse/WAGON-388
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-http, wagon-http-lightweight
> Affects Versions: 2.0, 2.4
> Reporter: Herve Boutemy
>
> AbstractHttpClientWagon uses classes from [HttpClient|http://hc.apache.org/httpcomponents-client-ga/httpclient/index.html]
> Lightweight wagon extends AbstractHttpClientWagon but uses JRE java.net classes
> AbstractHttpClientWagon should not depend on httpclient: it can depend on [HttpCore|http://hc.apache.org/httpcomponents-core-ga/index.html], if useful to share some utilities between wagon-http and wagon-http-lightweight, but not HttpClient
> Such separation, possible now that HttpComponents has 2 separate layers, will ease maintenance
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (WAGON-388) remove wagon-http-shared4 dependency on
httpclient
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/WAGON-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319828#comment-319828 ]
Olivier Lamy commented on WAGON-388:
------------------------------------
@Hervé currently master doesn't use HtmlFileListParser with jsoup
This one is in http-shared4 module.
> remove wagon-http-shared4 dependency on httpclient
> --------------------------------------------------
>
> Key: WAGON-388
> URL: https://jira.codehaus.org/browse/WAGON-388
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-http, wagon-http-lightweight
> Affects Versions: 2.0, 2.4
> Reporter: Herve Boutemy
> Assignee: Herve Boutemy
> Fix For: 2.5
>
>
> AbstractHttpClientWagon uses classes from [HttpClient|http://hc.apache.org/httpcomponents-client-ga/httpclient/index.html]
> Lightweight wagon extends AbstractHttpClientWagon but uses JRE java.net classes
> AbstractHttpClientWagon should not depend on httpclient: it can depend on [HttpCore|http://hc.apache.org/httpcomponents-core-ga/index.html], if useful to share some utilities between wagon-http and wagon-http-lightweight, but not HttpClient
> Such separation, possible now that HttpComponents has 2 separate layers, will ease maintenance
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira