You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Emilian Bold <em...@apache.org> on 2016/11/02 19:49:48 UTC

Initial code cleanup

Hello,

As part of the IP Clearance we must do an initial code clean up
<http://incubator.apache.org/guides/mentor.html#initial-clean-up>.

This includes looking for any potential licensing issues, such as using
code with one of the licenses that may not be included with Apache products
<https://www.apache.org/legal/resolved#category-x>.

I made a small shell script
<https://bitbucket.org/emilianbold/netbeans-cleanup/src/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.sh?at=default&fileviewer=file-view-default>
that you could run against the NetBeans working dir. (Of course, this may
be improved, etc)

An output CSV file against 9c074e250f9f (release82) is visible here
<https://bitbucket.org/emilianbold/netbeans-cleanup/raw/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.csv>
.

I believe it might help to have separate threads for each unrelated module
/ library.

Re: Initial code cleanup

Posted by Emilian Bold <em...@apache.org>.
I've posted for libs.nashorn
https://issues.apache.org/jira/browse/NETBEANS-2

Note the cleanup label.

On Thu, Nov 3, 2016 at 1:25 PM, Emilian Bold <em...@apache.org> wrote:

> lib.nashorn is also GPL with CPE and needed by the JavaScript editor.
>
>
> Pe miercuri, 2 noiembrie 2016, Emilian Bold <em...@apache.org> a scris:
>
>> Hello,
>>
>> As part of the IP Clearance we must do an initial code clean up
>> <http://incubator.apache.org/guides/mentor.html#initial-clean-up>.
>>
>> This includes looking for any potential licensing issues, such as using
>> code with one of the licenses that may not be included with Apache
>> products <https://www.apache.org/legal/resolved#category-x>.
>>
>> I made a small shell script
>> <https://bitbucket.org/emilianbold/netbeans-cleanup/src/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.sh?at=default&fileviewer=file-view-default>
>> that you could run against the NetBeans working dir. (Of course, this may
>> be improved, etc)
>>
>> An output CSV file against 9c074e250f9f (release82) is visible here
>> <https://bitbucket.org/emilianbold/netbeans-cleanup/raw/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.csv>
>> .
>>
>> I believe it might help to have separate threads for each unrelated
>> module / library.
>>
>>
>
> --
>
> --emi
>
>

Re: Initial code cleanup

Posted by Emilian Bold <em...@apache.org>.
lib.nashorn is also GPL with CPE and needed by the JavaScript editor.

Pe miercuri, 2 noiembrie 2016, Emilian Bold <em...@apache.org> a scris:

> Hello,
>
> As part of the IP Clearance we must do an initial code clean up
> <http://incubator.apache.org/guides/mentor.html#initial-clean-up>.
>
> This includes looking for any potential licensing issues, such as using
> code with one of the licenses that may not be included with Apache
> products <https://www.apache.org/legal/resolved#category-x>.
>
> I made a small shell script
> <https://bitbucket.org/emilianbold/netbeans-cleanup/src/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.sh?at=default&fileviewer=file-view-default>
> that you could run against the NetBeans working dir. (Of course, this may
> be improved, etc)
>
> An output CSV file against 9c074e250f9f (release82) is visible here
> <https://bitbucket.org/emilianbold/netbeans-cleanup/raw/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.csv>
> .
>
> I believe it might help to have separate threads for each unrelated module
> / library.
>
>

-- 

--emi

Re: Initial code cleanup

Posted by Emilian Bold <em...@apache.org>.
> or, my pick, just replace java help with online links then move the help
files to the wiki or some help site section.

Getting rid of javahelp would break a stable API for plugin developers and
Platform apps so we must also provide a migration path here.

On Wed, Nov 2, 2016 at 10:08 PM, Emilian Bold <em...@apache.org> wrote:

> Could a mentor confirm that GPL with Classpath Exception has the same
> treatment as GPL and LGPL? My impression is that GPL w/ CPE is also a
> category X license.
>
> javahelp seems to be under GNU GPL 2 with CPE and we do use it:
> http://hg.netbeans.org/releases/file/5fd841261bf9/javahe
> lp/external/jhall-2.0_05-license.txt
>
> So, we could either use another javahelp implementation (is there any?),
> or, my pick, just replace java help with online links then move the help
> files to the wiki or some help site section.
>
> --emi
>
>
> On Wed, Nov 2, 2016 at 9:49 PM, Emilian Bold <em...@apache.org> wrote:
>
>> Hello,
>>
>> As part of the IP Clearance we must do an initial code clean up
>> <http://incubator.apache.org/guides/mentor.html#initial-clean-up>.
>>
>> This includes looking for any potential licensing issues, such as using
>> code with one of the licenses that may not be included with Apache
>> products <https://www.apache.org/legal/resolved#category-x>.
>>
>> I made a small shell script
>> <https://bitbucket.org/emilianbold/netbeans-cleanup/src/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.sh?at=default&fileviewer=file-view-default>
>> that you could run against the NetBeans working dir. (Of course, this may
>> be improved, etc)
>>
>> An output CSV file against 9c074e250f9f (release82) is visible here
>> <https://bitbucket.org/emilianbold/netbeans-cleanup/raw/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.csv>
>> .
>>
>> I believe it might help to have separate threads for each unrelated
>> module / library.
>>
>>
>

Re: Initial code cleanup

Posted by Emilian Bold <em...@apache.org>.
I've posted for javahelp https://issues.apache.org/jira/browse/NETBEANS-3

On Wed, Nov 2, 2016 at 10:08 PM, Emilian Bold <em...@apache.org> wrote:

> Could a mentor confirm that GPL with Classpath Exception has the same
> treatment as GPL and LGPL? My impression is that GPL w/ CPE is also a
> category X license.
>
> javahelp seems to be under GNU GPL 2 with CPE and we do use it:
> http://hg.netbeans.org/releases/file/5fd841261bf9/javahe
> lp/external/jhall-2.0_05-license.txt
>
> So, we could either use another javahelp implementation (is there any?),
> or, my pick, just replace java help with online links then move the help
> files to the wiki or some help site section.
>
> --emi
>
>
> On Wed, Nov 2, 2016 at 9:49 PM, Emilian Bold <em...@apache.org> wrote:
>
>> Hello,
>>
>> As part of the IP Clearance we must do an initial code clean up
>> <http://incubator.apache.org/guides/mentor.html#initial-clean-up>.
>>
>> This includes looking for any potential licensing issues, such as using
>> code with one of the licenses that may not be included with Apache
>> products <https://www.apache.org/legal/resolved#category-x>.
>>
>> I made a small shell script
>> <https://bitbucket.org/emilianbold/netbeans-cleanup/src/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.sh?at=default&fileviewer=file-view-default>
>> that you could run against the NetBeans working dir. (Of course, this may
>> be improved, etc)
>>
>> An output CSV file against 9c074e250f9f (release82) is visible here
>> <https://bitbucket.org/emilianbold/netbeans-cleanup/raw/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.csv>
>> .
>>
>> I believe it might help to have separate threads for each unrelated
>> module / library.
>>
>>
>

Re: Initial code cleanup

Posted by Emilian Bold <em...@apache.org>.
Could a mentor confirm that GPL with Classpath Exception has the same
treatment as GPL and LGPL? My impression is that GPL w/ CPE is also a
category X license.

javahelp seems to be under GNU GPL 2 with CPE and we do use it:
http://hg.netbeans.org/releases/file/5fd841261bf9/
javahelp/external/jhall-2.0_05-license.txt

So, we could either use another javahelp implementation (is there any?),
or, my pick, just replace java help with online links then move the help
files to the wiki or some help site section.

--emi


On Wed, Nov 2, 2016 at 9:49 PM, Emilian Bold <em...@apache.org> wrote:

> Hello,
>
> As part of the IP Clearance we must do an initial code clean up
> <http://incubator.apache.org/guides/mentor.html#initial-clean-up>.
>
> This includes looking for any potential licensing issues, such as using
> code with one of the licenses that may not be included with Apache
> products <https://www.apache.org/legal/resolved#category-x>.
>
> I made a small shell script
> <https://bitbucket.org/emilianbold/netbeans-cleanup/src/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.sh?at=default&fileviewer=file-view-default>
> that you could run against the NetBeans working dir. (Of course, this may
> be improved, etc)
>
> An output CSV file against 9c074e250f9f (release82) is visible here
> <https://bitbucket.org/emilianbold/netbeans-cleanup/raw/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.csv>
> .
>
> I believe it might help to have separate threads for each unrelated module
> / library.
>
>

Re: Initial code cleanup

Posted by Emilian Bold <em...@gmail.com>.
Sure, once we have a task we move it to JIRA. But for initial talks I
personally prefer email.


--emi

On Wed, Nov 2, 2016 at 10:10 PM, Wade Chandler <me...@wadechandler.com> wrote:

> This sounds like a good task for the wiki or Jira where we can break
> things down into tables or tasks. Maybe use Jira for those; it allows us to
> comment on them and assign etc.
>
> Wade
>
>
> ===================
>
> Wade Chandler
> e: consult@wadechandler.com
>
>
>
> > On Nov 2, 2016, at 15:49, Emilian Bold <em...@apache.org> wrote:
> >
> > Hello,
> >
> > As part of the IP Clearance we must do an initial code clean up
> > <http://incubator.apache.org/guides/mentor.html#initial-clean-up>.
> >
> > This includes looking for any potential licensing issues, such as using
> > code with one of the licenses that may not be included with Apache
> products
> > <https://www.apache.org/legal/resolved#category-x>.
> >
> > I made a small shell script
> > <https://bitbucket.org/emilianbold/netbeans-cleanup/src/
> fcc27ea6165c6702ac48b2bcf93dea890de84969/license.sh?at=
> default&fileviewer=file-view-default>
> > that you could run against the NetBeans working dir. (Of course, this may
> > be improved, etc)
> >
> > An output CSV file against 9c074e250f9f (release82) is visible here
> > <https://bitbucket.org/emilianbold/netbeans-cleanup/raw/
> fcc27ea6165c6702ac48b2bcf93dea890de84969/license.csv>
> > .
> >
> > I believe it might help to have separate threads for each unrelated
> module
> > / library.
>
>

Re: Initial code cleanup

Posted by Wade Chandler <me...@wadechandler.com>.
This sounds like a good task for the wiki or Jira where we can break things down into tables or tasks. Maybe use Jira for those; it allows us to comment on them and assign etc.

Wade


===================

Wade Chandler
e: consult@wadechandler.com



> On Nov 2, 2016, at 15:49, Emilian Bold <em...@apache.org> wrote:
> 
> Hello,
> 
> As part of the IP Clearance we must do an initial code clean up
> <http://incubator.apache.org/guides/mentor.html#initial-clean-up>.
> 
> This includes looking for any potential licensing issues, such as using
> code with one of the licenses that may not be included with Apache products
> <https://www.apache.org/legal/resolved#category-x>.
> 
> I made a small shell script
> <https://bitbucket.org/emilianbold/netbeans-cleanup/src/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.sh?at=default&fileviewer=file-view-default>
> that you could run against the NetBeans working dir. (Of course, this may
> be improved, etc)
> 
> An output CSV file against 9c074e250f9f (release82) is visible here
> <https://bitbucket.org/emilianbold/netbeans-cleanup/raw/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.csv>
> .
> 
> I believe it might help to have separate threads for each unrelated module
> / library.


Re: Initial code cleanup

Posted by Emilian Bold <em...@apache.org>.
I've posted for nb-javac https://issues.apache.org/jira/browse/NETBEANS-1

On Thu, Nov 3, 2016 at 1:28 PM, Emilian Bold <em...@apache.org> wrote:

> lib.javacapi, javacimpl needs a nb-javac build which is GPL with CPE. Used
> by the Java editor.
>
> Pe miercuri, 2 noiembrie 2016, Emilian Bold <em...@apache.org> a scris:
>
>> Hello,
>>
>> As part of the IP Clearance we must do an initial code clean up
>> <http://incubator.apache.org/guides/mentor.html#initial-clean-up>.
>>
>> This includes looking for any potential licensing issues, such as using
>> code with one of the licenses that may not be included with Apache
>> products <https://www.apache.org/legal/resolved#category-x>.
>>
>> I made a small shell script
>> <https://bitbucket.org/emilianbold/netbeans-cleanup/src/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.sh?at=default&fileviewer=file-view-default>
>> that you could run against the NetBeans working dir. (Of course, this may
>> be improved, etc)
>>
>> An output CSV file against 9c074e250f9f (release82) is visible here
>> <https://bitbucket.org/emilianbold/netbeans-cleanup/raw/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.csv>
>> .
>>
>> I believe it might help to have separate threads for each unrelated
>> module / library.
>>
>>
>
> --
>
> --emi
>
>

Re: Initial code cleanup

Posted by Emilian Bold <em...@apache.org>.
lib.javacapi, javacimpl needs a nb-javac build which is GPL with CPE. Used
by the Java editor.

Pe miercuri, 2 noiembrie 2016, Emilian Bold <em...@apache.org> a scris:

> Hello,
>
> As part of the IP Clearance we must do an initial code clean up
> <http://incubator.apache.org/guides/mentor.html#initial-clean-up>.
>
> This includes looking for any potential licensing issues, such as using
> code with one of the licenses that may not be included with Apache
> products <https://www.apache.org/legal/resolved#category-x>.
>
> I made a small shell script
> <https://bitbucket.org/emilianbold/netbeans-cleanup/src/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.sh?at=default&fileviewer=file-view-default>
> that you could run against the NetBeans working dir. (Of course, this may
> be improved, etc)
>
> An output CSV file against 9c074e250f9f (release82) is visible here
> <https://bitbucket.org/emilianbold/netbeans-cleanup/raw/fcc27ea6165c6702ac48b2bcf93dea890de84969/license.csv>
> .
>
> I believe it might help to have separate threads for each unrelated module
> / library.
>
>

-- 

--emi