You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Regis Xu (JIRA)" <ji...@apache.org> on 2009/02/17 05:19:59 UTC
[jira] Created: (HARMONY-6092) [classlib][luni] - SocketInputStream
should check EOF before reading
[classlib][luni] - SocketInputStream should check EOF before reading
--------------------------------------------------------------------
Key: HARMONY-6092
URL: https://issues.apache.org/jira/browse/HARMONY-6092
Project: Harmony
Issue Type: Bug
Components: Classlib
Affects Versions: 5.0M8
Reporter: Regis Xu
Fix For: 5.0M9
after patch in HARMONY-6091, SocketTest.test_getInputStream is faild.
java.net.SocketException: Stream is closed
at org.apache.harmony.luni.net.SocketInputStream.checkClosed(SocketInputStream.java:18)
at org.apache.harmony.luni.net.SocketInputStream.read(SocketInputStream.java:66)
at org.apache.harmony.luni.tests.java.net.SocketTest.test_getInputStream(SocketTest.java:130)
at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
It seems RI check EOF before reading: if already reach EOF, read always return -1 on Windows, but on Linux, we could never readch EOF, instead, SocketException is throwed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-6092) [classlib][luni] - SocketInputStream
should check EOF before reading
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu closed HARMONY-6092.
-----------------------------
> [classlib][luni] - SocketInputStream should check EOF before reading
> --------------------------------------------------------------------
>
> Key: HARMONY-6092
> URL: https://issues.apache.org/jira/browse/HARMONY-6092
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M8
> Reporter: Regis Xu
> Assignee: Regis Xu
> Fix For: 5.0M10
>
> Attachments: HARMONY-6092.diff
>
>
> after patch in HARMONY-6091, SocketTest.test_getInputStream is faild.
> java.net.SocketException: Stream is closed
> at org.apache.harmony.luni.net.SocketInputStream.checkClosed(SocketInputStream.java:18)
> at org.apache.harmony.luni.net.SocketInputStream.read(SocketInputStream.java:66)
> at org.apache.harmony.luni.tests.java.net.SocketTest.test_getInputStream(SocketTest.java:130)
> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> It seems RI check EOF before reading: if already reach EOF, read always return -1 on Windows, but on Linux, we could never readch EOF, instead, SocketException is throwed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6092) [classlib][luni] - SocketInputStream
should check EOF before reading
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu updated HARMONY-6092:
------------------------------
Attachment: HARMONY-6092.diff
The patch add EOF check in read method of SocketInputStream, and alos refine the test case to work on different platform.
> [classlib][luni] - SocketInputStream should check EOF before reading
> --------------------------------------------------------------------
>
> Key: HARMONY-6092
> URL: https://issues.apache.org/jira/browse/HARMONY-6092
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M8
> Reporter: Regis Xu
> Fix For: 5.0M9
>
> Attachments: HARMONY-6092.diff
>
>
> after patch in HARMONY-6091, SocketTest.test_getInputStream is faild.
> java.net.SocketException: Stream is closed
> at org.apache.harmony.luni.net.SocketInputStream.checkClosed(SocketInputStream.java:18)
> at org.apache.harmony.luni.net.SocketInputStream.read(SocketInputStream.java:66)
> at org.apache.harmony.luni.tests.java.net.SocketTest.test_getInputStream(SocketTest.java:130)
> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> It seems RI check EOF before reading: if already reach EOF, read always return -1 on Windows, but on Linux, we could never readch EOF, instead, SocketException is throwed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6092) [classlib][luni] -
SocketInputStream should check EOF before reading
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699982#action_12699982 ]
Regis Xu commented on HARMONY-6092:
-----------------------------------
The test is still failed on Linux, and RI failed with the exception, seem the test case's problem, will fix the test case.
> [classlib][luni] - SocketInputStream should check EOF before reading
> --------------------------------------------------------------------
>
> Key: HARMONY-6092
> URL: https://issues.apache.org/jira/browse/HARMONY-6092
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M8
> Reporter: Regis Xu
> Assignee: Sean Qiu
> Fix For: 5.0M9
>
> Attachments: HARMONY-6092.diff
>
>
> after patch in HARMONY-6091, SocketTest.test_getInputStream is faild.
> java.net.SocketException: Stream is closed
> at org.apache.harmony.luni.net.SocketInputStream.checkClosed(SocketInputStream.java:18)
> at org.apache.harmony.luni.net.SocketInputStream.read(SocketInputStream.java:66)
> at org.apache.harmony.luni.tests.java.net.SocketTest.test_getInputStream(SocketTest.java:130)
> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> It seems RI check EOF before reading: if already reach EOF, read always return -1 on Windows, but on Linux, we could never readch EOF, instead, SocketException is throwed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6092) [classlib][luni] -
SocketInputStream should check EOF before reading
Posted by "Sean Qiu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Qiu reassigned HARMONY-6092:
---------------------------------
Assignee: Sean Qiu
> [classlib][luni] - SocketInputStream should check EOF before reading
> --------------------------------------------------------------------
>
> Key: HARMONY-6092
> URL: https://issues.apache.org/jira/browse/HARMONY-6092
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M8
> Reporter: Regis Xu
> Assignee: Sean Qiu
> Fix For: 5.0M9
>
> Attachments: HARMONY-6092.diff
>
>
> after patch in HARMONY-6091, SocketTest.test_getInputStream is faild.
> java.net.SocketException: Stream is closed
> at org.apache.harmony.luni.net.SocketInputStream.checkClosed(SocketInputStream.java:18)
> at org.apache.harmony.luni.net.SocketInputStream.read(SocketInputStream.java:66)
> at org.apache.harmony.luni.tests.java.net.SocketTest.test_getInputStream(SocketTest.java:130)
> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> It seems RI check EOF before reading: if already reach EOF, read always return -1 on Windows, but on Linux, we could never readch EOF, instead, SocketException is throwed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6092) [classlib][luni] -
SocketInputStream should check EOF before reading
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu reassigned HARMONY-6092:
---------------------------------
Assignee: Regis Xu (was: Sean Qiu)
> [classlib][luni] - SocketInputStream should check EOF before reading
> --------------------------------------------------------------------
>
> Key: HARMONY-6092
> URL: https://issues.apache.org/jira/browse/HARMONY-6092
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M8
> Reporter: Regis Xu
> Assignee: Regis Xu
> Fix For: 5.0M9
>
> Attachments: HARMONY-6092.diff
>
>
> after patch in HARMONY-6091, SocketTest.test_getInputStream is faild.
> java.net.SocketException: Stream is closed
> at org.apache.harmony.luni.net.SocketInputStream.checkClosed(SocketInputStream.java:18)
> at org.apache.harmony.luni.net.SocketInputStream.read(SocketInputStream.java:66)
> at org.apache.harmony.luni.tests.java.net.SocketTest.test_getInputStream(SocketTest.java:130)
> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> It seems RI check EOF before reading: if already reach EOF, read always return -1 on Windows, but on Linux, we could never readch EOF, instead, SocketException is throwed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6092) [classlib][luni] -
SocketInputStream should check EOF before reading
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699692#action_12699692 ]
Tim Ellison commented on HARMONY-6092:
--------------------------------------
Can this be closed now?
> [classlib][luni] - SocketInputStream should check EOF before reading
> --------------------------------------------------------------------
>
> Key: HARMONY-6092
> URL: https://issues.apache.org/jira/browse/HARMONY-6092
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M8
> Reporter: Regis Xu
> Assignee: Sean Qiu
> Fix For: 5.0M9
>
> Attachments: HARMONY-6092.diff
>
>
> after patch in HARMONY-6091, SocketTest.test_getInputStream is faild.
> java.net.SocketException: Stream is closed
> at org.apache.harmony.luni.net.SocketInputStream.checkClosed(SocketInputStream.java:18)
> at org.apache.harmony.luni.net.SocketInputStream.read(SocketInputStream.java:66)
> at org.apache.harmony.luni.tests.java.net.SocketTest.test_getInputStream(SocketTest.java:130)
> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> It seems RI check EOF before reading: if already reach EOF, read always return -1 on Windows, but on Linux, we could never readch EOF, instead, SocketException is throwed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6092) [classlib][luni] -
SocketInputStream should check EOF before reading
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679111#action_12679111 ]
Regis Xu commented on HARMONY-6092:
-----------------------------------
I believe after patches 6090 and 6091, the crash could be fixed and SocketTest.test_getInputStream could be passed.
> [classlib][luni] - SocketInputStream should check EOF before reading
> --------------------------------------------------------------------
>
> Key: HARMONY-6092
> URL: https://issues.apache.org/jira/browse/HARMONY-6092
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M8
> Reporter: Regis Xu
> Assignee: Sean Qiu
> Fix For: 5.0M9
>
> Attachments: HARMONY-6092.diff
>
>
> after patch in HARMONY-6091, SocketTest.test_getInputStream is faild.
> java.net.SocketException: Stream is closed
> at org.apache.harmony.luni.net.SocketInputStream.checkClosed(SocketInputStream.java:18)
> at org.apache.harmony.luni.net.SocketInputStream.read(SocketInputStream.java:66)
> at org.apache.harmony.luni.tests.java.net.SocketTest.test_getInputStream(SocketTest.java:130)
> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> It seems RI check EOF before reading: if already reach EOF, read always return -1 on Windows, but on Linux, we could never readch EOF, instead, SocketException is throwed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6092) [classlib][luni] -
SocketInputStream should check EOF before reading
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Regis Xu resolved HARMONY-6092.
-------------------------------
Resolution: Fixed
Fix Version/s: (was: 5.0M9)
5.0M10
Test case fixed at r765837.
> [classlib][luni] - SocketInputStream should check EOF before reading
> --------------------------------------------------------------------
>
> Key: HARMONY-6092
> URL: https://issues.apache.org/jira/browse/HARMONY-6092
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M8
> Reporter: Regis Xu
> Assignee: Regis Xu
> Fix For: 5.0M10
>
> Attachments: HARMONY-6092.diff
>
>
> after patch in HARMONY-6091, SocketTest.test_getInputStream is faild.
> java.net.SocketException: Stream is closed
> at org.apache.harmony.luni.net.SocketInputStream.checkClosed(SocketInputStream.java:18)
> at org.apache.harmony.luni.net.SocketInputStream.read(SocketInputStream.java:66)
> at org.apache.harmony.luni.tests.java.net.SocketTest.test_getInputStream(SocketTest.java:130)
> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> It seems RI check EOF before reading: if already reach EOF, read always return -1 on Windows, but on Linux, we could never readch EOF, instead, SocketException is throwed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.