You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Will Glass-Husain (JIRA)" <ji...@apache.org> on 2006/01/17 09:41:42 UTC
[jira] Created: (VELOCITY-430) Allow commas or spaces to separate
macro arguments
Allow commas or spaces to separate macro arguments
--------------------------------------------------
Key: VELOCITY-430
URL: http://issues.apache.org/jira/browse/VELOCITY-430
Project: Velocity
Type: Improvement
Components: Source
Reporter: Will Glass-Husain
Assigned to: Will Glass-Husain
Priority: Minor
Fix For: 1.5
If there is a macro "displayNotes", it'd be nice to allow
#displayNotes("note1" "note2") OR
#displayNotes("note1" ,"note2")
Allowing macros to support comma separated arguments like almost every programming language in existence. This never made sense to me.
Anyone object to adding this?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Closed: (VELOCITY-430) Allow commas or spaces to separate
macro arguments
Posted by "Henning Schmiedehausen (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen closed VELOCITY-430.
-------------------------------------------
> Allow commas or spaces to separate macro arguments
> --------------------------------------------------
>
> Key: VELOCITY-430
> URL: https://issues.apache.org/jira/browse/VELOCITY-430
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Reporter: Will Glass-Husain
> Assigned To: Will Glass-Husain
> Priority: Minor
> Fix For: 1.5
>
>
> If there is a macro "displayNotes", it'd be nice to allow
> #displayNotes("note1" "note2") OR
> #displayNotes("note1" ,"note2")
> Allowing macros to support comma separated arguments like almost every programming language in existence. This never made sense to me.
> Anyone object to adding this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-430) Allow commas or spaces to separate
macro arguments
Posted by "Will Glass-Husain (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-430?page=comments#action_12363132 ]
Will Glass-Husain commented on VELOCITY-430:
--------------------------------------------
Hi Daniel,
Thanks for the comment!
Your message confuses me. It's a usability improvement to make this change or to leave it out? (are you arguing for or against in the last sentence?)
I definitely think this is a usability improvement. I'm an experienced Velocity user, yet I build templates all the times with syntax errors due to typing commas in macro arguments. Why make users think twice about this?
I'm not worried about behavior -- it seems a small tweak to the parser with localized influence. Our regression tests will ensure stability...
> Allow commas or spaces to separate macro arguments
> --------------------------------------------------
>
> Key: VELOCITY-430
> URL: http://issues.apache.org/jira/browse/VELOCITY-430
> Project: Velocity
> Type: Improvement
> Components: Source
> Reporter: Will Glass-Husain
> Assignee: Will Glass-Husain
> Priority: Minor
> Fix For: 1.5
>
> If there is a macro "displayNotes", it'd be nice to allow
> #displayNotes("note1" "note2") OR
> #displayNotes("note1" ,"note2")
> Allowing macros to support comma separated arguments like almost every programming language in existence. This never made sense to me.
> Anyone object to adding this?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Commented: (VELOCITY-430) Allow commas or spaces to separate
macro arguments
Posted by "Daniel Rall (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-430?page=comments#action_12363127 ]
Daniel Rall commented on VELOCITY-430:
--------------------------------------
It seems like a needless complication to the parser to muck with a long-standing behavior (albeit in a backwards compatible manner). Additionally, this change reduces the syntactic difference between Velocimacro and Java object invocation (leaving the $/#, and possibily formal reference notation differences); this part could be construed as an usability improvement.
> Allow commas or spaces to separate macro arguments
> --------------------------------------------------
>
> Key: VELOCITY-430
> URL: http://issues.apache.org/jira/browse/VELOCITY-430
> Project: Velocity
> Type: Improvement
> Components: Source
> Reporter: Will Glass-Husain
> Assignee: Will Glass-Husain
> Priority: Minor
> Fix For: 1.5
>
> If there is a macro "displayNotes", it'd be nice to allow
> #displayNotes("note1" "note2") OR
> #displayNotes("note1" ,"note2")
> Allowing macros to support comma separated arguments like almost every programming language in existence. This never made sense to me.
> Anyone object to adding this?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Commented: (VELOCITY-430) Allow commas or spaces to separate
macro arguments
Posted by "Daniel Rall (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-430?page=comments#action_12363185 ]
Daniel Rall commented on VELOCITY-430:
--------------------------------------
Supporting the use of commas in Velocimacro invocation (and possibly, definition) is an usability improvement.
> Allow commas or spaces to separate macro arguments
> --------------------------------------------------
>
> Key: VELOCITY-430
> URL: http://issues.apache.org/jira/browse/VELOCITY-430
> Project: Velocity
> Type: Improvement
> Components: Source
> Reporter: Will Glass-Husain
> Assignee: Will Glass-Husain
> Priority: Minor
> Fix For: 1.5
>
> If there is a macro "displayNotes", it'd be nice to allow
> #displayNotes("note1" "note2") OR
> #displayNotes("note1" ,"note2")
> Allowing macros to support comma separated arguments like almost every programming language in existence. This never made sense to me.
> Anyone object to adding this?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Resolved: (VELOCITY-430) Allow commas or spaces to separate
macro arguments
Posted by "Will Glass-Husain (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-430?page=all ]
Will Glass-Husain resolved VELOCITY-430:
----------------------------------------
Resolution: Fixed
Implemented this in rev# 373465. Let me know what you think. If it seems like a good approach we can change the docs to use commas instead of spaces.
> Allow commas or spaces to separate macro arguments
> --------------------------------------------------
>
> Key: VELOCITY-430
> URL: http://issues.apache.org/jira/browse/VELOCITY-430
> Project: Velocity
> Type: Improvement
> Components: Source
> Reporter: Will Glass-Husain
> Assignee: Will Glass-Husain
> Priority: Minor
> Fix For: 1.5
>
> If there is a macro "displayNotes", it'd be nice to allow
> #displayNotes("note1" "note2") OR
> #displayNotes("note1" ,"note2")
> Allowing macros to support comma separated arguments like almost every programming language in existence. This never made sense to me.
> Anyone object to adding this?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org