You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Dev-iL (via GitHub)" <gi...@apache.org> on 2026/03/01 12:40:07 UTC
Re: [PR] Add self-review checklist for AI agents in AGENTS.md [airflow]
Dev-iL commented on code in PR #62617:
URL: https://github.com/apache/airflow/pull/62617#discussion_r2868965875
##########
AGENTS.md:
##########
@@ -95,6 +99,21 @@ That is the user's fork remote. If no such remote exists, create the fork and ad
gh repo fork apache/airflow --remote --remote-name <GITHUB_USER>
```
+Before pushing, perform a self-review of your changes following the Gen-AI review guidelines
+in [`contributing-docs/05_pull_requests.rst`](contributing-docs/05_pull_requests.rst) and the
+code review checklist in [`.github/instructions/code-review.instructions.md`](.github/instructions/code-review.instructions.md):
+
+1. Review the full diff (`git diff main...HEAD`) and verify every change is intentional and
+ related to the task — remove any unrelated changes.
+2. Read `.github/instructions/code-review.instructions.md` and check your diff against every
+ rule — architecture boundaries, database correctness, code quality, testing requirements,
+ API correctness, and AI-generated code signals. Fix any violations before pushing.
+3. Confirm the code follows the project's coding standards and architecture boundaries
+ described in this file.
+4. Run static checks (`prek run --ref-from <target_branch>`) and fix any failures.
+5. Run relevant tests (`breeze run pytest <path> -xvs`) and confirm they pass.
Review Comment:
A type checking stage should be included too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org