[GitHub] jonpspri commented on issue #3133: Subtle changes to support S390X deployment of OpenWhisk

[GitBox <gi...@apache.org>]

jonpspri commented on issue #3133: Subtle changes to support S390X deployment of OpenWhisk
URL: https://github.com/apache/incubator-openwhisk/pull/3133#issuecomment-353756150
 
 
   @dgrove-oss Thanks for pointing out #3100.  I have two concerns, one of which is directly related to adding s390x, and one of which is something I've been scratching my head about anyway.
   
   1. I did away with 'cli_arch' and only reluctantly kept 'cli_os' as ansible variables.  Instead, I introduced 'cli_os_arch' to list VALID combinations of os and architecture.  In particular, when I added 's390x' arch, 'mac' and 'windows' did not make sense as OSs.  Therefore I enumerated valid pairs.  In the new code in #3100, there's still a nested loop of cli_os and cli_arch to create the directory structure.  I can fix it if 3100 goes first, but perhaps we should unify on a strategy, which brings me to...
   
   1. The treatment of `bin/wsk`.  I'm at a loss here -- what's the appropriate action for this binary in each of the three modes?  Here, the binary is being used locally to execute OpenWhisk actions, so we need to have it on the filesystem, but we either download it or copy it from the local build in the next project over.  I suppose the appropriate actions are [ local: copy, remote: download, remote_redirect: download ], but I'm not sure either of us has it that way right now.  I can tweak it if I go second, but it may be worth a second look at #3100.  I'm not sure I have rights to comment at the point over there, but I'll try to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services