You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "asf-gitbox-commits (via GitHub)" <gi...@apache.org> on 2026/05/15 22:59:40 UTC
[PR] [INFRA] Set up default rulesets for default and release branches [thrift-website]
asf-gitbox-commits opened a new pull request, #22:
URL: https://github.com/apache/thrift-website/pull/22
This Pull Request enables the repository to conform with the "sane default security settings" of the Apache Software Foundation by configuring a default branch ruleset that protects the default branch and any release branches.
Note that `~DEFAULT_BRANCH` is a GitHub symbolic link to the current default branch (HEAD) of the repository and does not need changing.
If the managing project does not wish to set up these defaults, please close this Pull Request. Alternatively, the project may merge this Pull Request to apply the changes immediately.
If no action is taken, this Pull Request will be automatically merged by the Apache Infrastructure team on **2026-06-14** (30 days from now).
For any further information, please reach us on Slack or at: users@infra.apache.org
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INFRA] Set up default rulesets for default and release branches [thrift-website]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #22:
URL: https://github.com/apache/thrift-website/pull/22#discussion_r3253338577
##########
.asf.yaml:
##########
@@ -31,12 +31,25 @@ github:
issues: false
projects: false
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
+ excludes: []
+ bypass_teams:
+ - root
+ restrict_deletion: true
+ restrict_force_push: true
staging:
- profile: ~
- whoami: asf-staging
+ profile:
Review Comment:
This change doesn't matter. The tilde helps make it explicit, and protect against typos or user confusion when the value is empty. I restored it to minimize the pull request differences and to make it explicit, so it looks like the asf.yaml example in the documentation. Discussion of this part of the PR is a waste of time. Let's focus on the release tag naming conventions please. That's the part that actually matters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INFRA] Set up default rulesets for default and release branches [thrift-website]
Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk commented on code in PR #22:
URL: https://github.com/apache/thrift-website/pull/22#discussion_r3251671514
##########
.asf.yaml:
##########
@@ -31,12 +31,25 @@ github:
issues: false
projects: false
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
+ excludes: []
+ bypass_teams:
+ - root
+ restrict_deletion: true
+ restrict_force_push: true
staging:
- profile: ~
- whoami: asf-staging
+ profile:
Review Comment:
In Ruby, there is no difference
```
irb(main):004> YAML.load("---\nhello:")
=> {"hello" => nil}
irb(main):005> YAML.load("---\nhello: ~")
=> {"hello" => nil}
```
🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INFRA] Set up default rulesets for default and release branches [thrift-website]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii merged PR #22:
URL: https://github.com/apache/thrift-website/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INFRA] Set up default rulesets for default and release branches [thrift-website]
Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk commented on code in PR #22:
URL: https://github.com/apache/thrift-website/pull/22#discussion_r3251669271
##########
.asf.yaml:
##########
@@ -31,12 +31,25 @@ github:
issues: false
projects: false
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
+ excludes: []
+ bypass_teams:
+ - root
+ restrict_deletion: true
+ restrict_force_push: true
staging:
- profile: ~
- whoami: asf-staging
+ profile:
Review Comment:
Wonder if this is a yaml generator issue, of not longer an issue if the parser can read absence of value as "no value"... https://github.com/apache/infrastructure-asfyaml/blob/main/README.md#staging-a-web-site-preview-domain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INFRA] Set up default rulesets for default and release branches [thrift-website]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #22:
URL: https://github.com/apache/thrift-website/pull/22#discussion_r3251570064
##########
.asf.yaml:
##########
@@ -31,12 +31,25 @@ github:
issues: false
projects: false
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
+ - "rel/*"
+ excludes: []
+ bypass_teams:
+ - root
+ restrict_deletion: true
+ restrict_force_push: true
staging:
- profile: ~
- whoami: asf-staging
+ profile:
Review Comment:
```suggestion
profile: ~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org