[GitHub] AlexanderKaraberov commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

[GitBox <gi...@apache.org>]

AlexanderKaraberov commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
URL: https://github.com/apache/couchdb/pull/1195#discussion_r232008802
 
 

 ##########
 File path: src/chttpd/src/chttpd_db.erl
 ##########
 @@ -932,7 +973,39 @@ send_doc_efficiently(#httpd{mochi_req=MochiReq}=Req, #doc{atts=Atts}=Doc, Header
         send_json(Req, 200, Headers, couch_doc:to_json_obj(Doc, Options))
     end.
 
-send_docs_multipart(Req, Results, Options1) ->
+send_docs_multipart(bulk_get, _Req, Results, Options1, OuterBoundary, Resp) ->
 
 Review comment:
   Hi @nickva  and thanks for review and your comments. Will definitely address this. I should have thought about fixing all this formatting mess before. One question for you: in your opinion is it OK to have `send_docs_multipart` reimplemented as a separate function clause tagged with atom `bulk_get`? If it's _clearer_ to reimplement this as a separate 3 param function then i will definitely address this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services