You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Elliot Metsger (JIRA)" <ji...@codehaus.org> on 2007/03/30 05:43:37 UTC
[jira] Created: (MRRESOURCES-21) Supplement the data model used by
Velocity
Supplement the data model used by Velocity
------------------------------------------
Key: MRRESOURCES-21
URL: http://jira.codehaus.org/browse/MRRESOURCES-21
Project: Maven 2.x Remote Resources Plugin
Issue Type: Improvement
Affects Versions: 1.0-alpha-4
Environment: https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-remote-resources-plugin r523911.
Reporter: Elliot Metsger
Priority: Minor
Related to MRRESOURCES-2, I'd like to be able to deal with artifacts that have incomplete POM's, because incomplete NOTICE files are generated.
But instead of having the MRRP append to a locally managed NOTICE file like MRRESOURCES-2, I'd like to augment the data model used by Velocity.
The idea is that MRR plugin will take a parameter to a file which contains POM XML snippits. The ModelInheritanceAssembler merges the POM XML snippits with the actual artifact POM. Thoughts? I'll plan on submitting a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRRESOURCES-21) Supplement the data model used
by Velocity
Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_92383 ]
Daniel Kulp commented on MRRESOURCES-21:
----------------------------------------
I'm going to use most of this patch. Thanks a bunch.
The main change I'm going to make is to make supplementalModelFile an array of Strings (called supplementalModels) and use a ResourceManager to obtain them. The main benifit this has is that supplements can be stored in a jar that is added as a dependency to the plugin, much like checkstyle/pmd config files. You can also have multiple files. Some as dependencies, some in the src tree, etc...
> Supplement the data model used by Velocity
> ------------------------------------------
>
> Key: MRRESOURCES-21
> URL: http://jira.codehaus.org/browse/MRRESOURCES-21
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-4
> Environment: https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-remote-resources-plugin r523911.
> Reporter: Elliot Metsger
> Assignee: Daniel Kulp
> Priority: Minor
> Fix For: 1.0-alpha-5
>
> Attachments: MRRP-21.patch, MRRP-21.patch
>
>
> Related to MRRESOURCES-2, I'd like to be able to deal with artifacts that have incomplete POM's, because incomplete NOTICE files are generated.
> But instead of having the MRRP append to a locally managed NOTICE file like MRRESOURCES-2, I'd like to augment the data model used by Velocity.
> The idea is that MRR plugin will take a parameter to a file which contains POM XML snippits. The ModelInheritanceAssembler merges the POM XML snippits with the actual artifact POM. Thoughts? I'll plan on submitting a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRRESOURCES-21) Supplement the data model used
by Velocity
Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_92477 ]
Daniel Kulp commented on MRRESOURCES-21:
----------------------------------------
One more change. I'm setting the type in the MDO file to DOM. Thus, the data will be true XML instead of big CDATA sections. It can then be easier to edit in an XML editor and such.
> Supplement the data model used by Velocity
> ------------------------------------------
>
> Key: MRRESOURCES-21
> URL: http://jira.codehaus.org/browse/MRRESOURCES-21
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-4
> Environment: https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-remote-resources-plugin r523911.
> Reporter: Elliot Metsger
> Assignee: Daniel Kulp
> Priority: Minor
> Fix For: 1.0-alpha-5
>
> Attachments: MRRP-21.patch, MRRP-21.patch
>
>
> Related to MRRESOURCES-2, I'd like to be able to deal with artifacts that have incomplete POM's, because incomplete NOTICE files are generated.
> But instead of having the MRRP append to a locally managed NOTICE file like MRRESOURCES-2, I'd like to augment the data model used by Velocity.
> The idea is that MRR plugin will take a parameter to a file which contains POM XML snippits. The ModelInheritanceAssembler merges the POM XML snippits with the actual artifact POM. Thoughts? I'll plan on submitting a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRRESOURCES-21) Supplement the data model used
by Velocity
Posted by "Elliot Metsger (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_92387 ]
Elliot Metsger commented on MRRESOURCES-21:
-------------------------------------------
Awesome, that's a major improvement to what I had. Sorry about the quality of the patch, I really did more refactoring than was needed possibly making the patch more difficult to apply. I'll look forward to the alpha-5 release of MRRP! Thanks again, Elliot.
> Supplement the data model used by Velocity
> ------------------------------------------
>
> Key: MRRESOURCES-21
> URL: http://jira.codehaus.org/browse/MRRESOURCES-21
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-4
> Environment: https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-remote-resources-plugin r523911.
> Reporter: Elliot Metsger
> Assignee: Daniel Kulp
> Priority: Minor
> Fix For: 1.0-alpha-5
>
> Attachments: MRRP-21.patch, MRRP-21.patch
>
>
> Related to MRRESOURCES-2, I'd like to be able to deal with artifacts that have incomplete POM's, because incomplete NOTICE files are generated.
> But instead of having the MRRP append to a locally managed NOTICE file like MRRESOURCES-2, I'd like to augment the data model used by Velocity.
> The idea is that MRR plugin will take a parameter to a file which contains POM XML snippits. The ModelInheritanceAssembler merges the POM XML snippits with the actual artifact POM. Thoughts? I'll plan on submitting a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRRESOURCES-21) Supplement the data model used by
Velocity
Posted by "Elliot Metsger (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliot Metsger updated MRRESOURCES-21:
--------------------------------------
Attachment: MRRP-21.patch
Updating patch, forgot to include the mdo.
> Supplement the data model used by Velocity
> ------------------------------------------
>
> Key: MRRESOURCES-21
> URL: http://jira.codehaus.org/browse/MRRESOURCES-21
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-4
> Environment: https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-remote-resources-plugin r523911.
> Reporter: Elliot Metsger
> Priority: Minor
> Attachments: MRRP-21.patch, MRRP-21.patch
>
>
> Related to MRRESOURCES-2, I'd like to be able to deal with artifacts that have incomplete POM's, because incomplete NOTICE files are generated.
> But instead of having the MRRP append to a locally managed NOTICE file like MRRESOURCES-2, I'd like to augment the data model used by Velocity.
> The idea is that MRR plugin will take a parameter to a file which contains POM XML snippits. The ModelInheritanceAssembler merges the POM XML snippits with the actual artifact POM. Thoughts? I'll plan on submitting a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRRESOURCES-21) Supplement the data model used
by Velocity
Posted by "Elliot Metsger (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_92478 ]
Elliot Metsger commented on MRRESOURCES-21:
-------------------------------------------
Ah, that's how you do that. My modello foo failed me - I had a little bit of difficulty with the Modello docs. Good to know about the DOM type!
> Supplement the data model used by Velocity
> ------------------------------------------
>
> Key: MRRESOURCES-21
> URL: http://jira.codehaus.org/browse/MRRESOURCES-21
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-4
> Environment: https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-remote-resources-plugin r523911.
> Reporter: Elliot Metsger
> Assignee: Daniel Kulp
> Priority: Minor
> Fix For: 1.0-alpha-5
>
> Attachments: MRRP-21.patch, MRRP-21.patch
>
>
> Related to MRRESOURCES-2, I'd like to be able to deal with artifacts that have incomplete POM's, because incomplete NOTICE files are generated.
> But instead of having the MRRP append to a locally managed NOTICE file like MRRESOURCES-2, I'd like to augment the data model used by Velocity.
> The idea is that MRR plugin will take a parameter to a file which contains POM XML snippits. The ModelInheritanceAssembler merges the POM XML snippits with the actual artifact POM. Thoughts? I'll plan on submitting a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MRRESOURCES-21) Supplement the data model used by
Velocity
Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp closed MRRESOURCES-21.
----------------------------------
Resolution: Fixed
> Supplement the data model used by Velocity
> ------------------------------------------
>
> Key: MRRESOURCES-21
> URL: http://jira.codehaus.org/browse/MRRESOURCES-21
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-4
> Environment: https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-remote-resources-plugin r523911.
> Reporter: Elliot Metsger
> Assignee: Daniel Kulp
> Priority: Minor
> Fix For: 1.0-alpha-5
>
> Attachments: MRRP-21.patch, MRRP-21.patch
>
>
> Related to MRRESOURCES-2, I'd like to be able to deal with artifacts that have incomplete POM's, because incomplete NOTICE files are generated.
> But instead of having the MRRP append to a locally managed NOTICE file like MRRESOURCES-2, I'd like to augment the data model used by Velocity.
> The idea is that MRR plugin will take a parameter to a file which contains POM XML snippits. The ModelInheritanceAssembler merges the POM XML snippits with the actual artifact POM. Thoughts? I'll plan on submitting a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRRESOURCES-21) Supplement the data model used by
Velocity
Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp updated MRRESOURCES-21:
-----------------------------------
Fix Version/s: 1.0-alpha-5
> Supplement the data model used by Velocity
> ------------------------------------------
>
> Key: MRRESOURCES-21
> URL: http://jira.codehaus.org/browse/MRRESOURCES-21
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-4
> Environment: https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-remote-resources-plugin r523911.
> Reporter: Elliot Metsger
> Assignee: Daniel Kulp
> Priority: Minor
> Fix For: 1.0-alpha-5
>
> Attachments: MRRP-21.patch, MRRP-21.patch
>
>
> Related to MRRESOURCES-2, I'd like to be able to deal with artifacts that have incomplete POM's, because incomplete NOTICE files are generated.
> But instead of having the MRRP append to a locally managed NOTICE file like MRRESOURCES-2, I'd like to augment the data model used by Velocity.
> The idea is that MRR plugin will take a parameter to a file which contains POM XML snippits. The ModelInheritanceAssembler merges the POM XML snippits with the actual artifact POM. Thoughts? I'll plan on submitting a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRRESOURCES-21) Supplement the data model used by
Velocity
Posted by "Elliot Metsger (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Elliot Metsger updated MRRESOURCES-21:
--------------------------------------
Attachment: MRRP-21.patch
Attached is a patch for this issue. I'm not in love with the names. Instead of "supplemental model" perhaps "stub model" is better/more accurate terminology.
It allows a new <configuration> element, <supplementalModelFile>. By default ${appendedResourceDirectory}/supplemental-models.xml is looked for, but can be overridden:
<configuration>
<supplementalModelFile>path/to/supplemental-models.xml</supplementalModelFile> <resourceBundles>
<resourceBundle>org.apache:apache-jar-resource-bundle:1.2</resourceBundle>
</resourceBundles>
</configuration>
The supplemental model file looks like this:
<?xml version="1.0" encoding="UTF-8"?>
<supplementalDataModels>
<supplements>
<supplement>
<![CDATA[
<project>
<groupId>xerces</groupId>
<artifactId>xmlParserAPIs</artifactId>
<name>Apache Xerces</name>
<url>http://xerces.apache.org/</url>
<organization>
<name>Apache Software Foundation</name>
<url>http://www.apache.org/</url>
</organization>
</project>
]]>
</supplement>
</supplements>
</supplementalDataModels>
The patch includes a Modello model for the supplemental-model.xml file.
> Supplement the data model used by Velocity
> ------------------------------------------
>
> Key: MRRESOURCES-21
> URL: http://jira.codehaus.org/browse/MRRESOURCES-21
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-4
> Environment: https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-remote-resources-plugin r523911.
> Reporter: Elliot Metsger
> Priority: Minor
> Attachments: MRRP-21.patch
>
>
> Related to MRRESOURCES-2, I'd like to be able to deal with artifacts that have incomplete POM's, because incomplete NOTICE files are generated.
> But instead of having the MRRP append to a locally managed NOTICE file like MRRESOURCES-2, I'd like to augment the data model used by Velocity.
> The idea is that MRR plugin will take a parameter to a file which contains POM XML snippits. The ModelInheritanceAssembler merges the POM XML snippits with the actual artifact POM. Thoughts? I'll plan on submitting a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira