[GitHub] [beam] aaltay commented on a change in pull request #12318: [BEAM-10538] Add cross-platform test suite on GitHub Actions

[GitBox <gi...@apache.org>]

aaltay commented on a change in pull request #12318:
URL: https://github.com/apache/beam/pull/12318#discussion_r457755302



##########
File path: sdks/python/tox.ini
##########
@@ -33,6 +33,7 @@ extras = test
 whitelist_externals =
   false
   time
+  bash

Review comment:
       If we are running this in windows, does this mean, bash, time etc. needs to be available in the windows installation? Are they available in the github provided image?

##########
File path: sdks/python/apache_beam/io/parquetio_test.py
##########
@@ -296,7 +296,9 @@ def test_sink_transform_int96(self):
               path, self.SCHEMA96, num_shards=1, shard_name_template='')
 
   def test_sink_transform(self):
-    with tempfile.NamedTemporaryFile() as dst:
+    dst = tempfile.NamedTemporaryFile()

Review comment:
       What is the reason for this change? (Is it because temp files cannot be re-opened in Windows?)
   
   After dst.close() the file could be deleted anytime and that will make the test flaky. You can use tempfile.mkstemp() instead, which moves the cleanup requirement to the caller.

##########
File path: .github/workflows/ci.yml
##########
@@ -0,0 +1,442 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: CI

Review comment:
       Is this identical to `build_wheels.yml`? What needs to be reviewed? why the name change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org