You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ho...@apache.org on 2011/02/19 02:33:13 UTC
svn commit: r1072230 -
/lucene/dev/trunk/solr/contrib/dataimporthandler/src/extras/test/java/org/apache/solr/handler/dataimport/TestTikaEntityProcessor.java
Author: hossman
Date: Sat Feb 19 01:33:12 2011
New Revision: 1072230
URL: http://svn.apache.org/viewvc?rev=1072230&view=rev
Log:
this test was missing @Test, and wasn't actually checking any fields were added
Modified:
lucene/dev/trunk/solr/contrib/dataimporthandler/src/extras/test/java/org/apache/solr/handler/dataimport/TestTikaEntityProcessor.java
Modified: lucene/dev/trunk/solr/contrib/dataimporthandler/src/extras/test/java/org/apache/solr/handler/dataimport/TestTikaEntityProcessor.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/extras/test/java/org/apache/solr/handler/dataimport/TestTikaEntityProcessor.java?rev=1072230&r1=1072229&r2=1072230&view=diff
==============================================================================
--- lucene/dev/trunk/solr/contrib/dataimporthandler/src/extras/test/java/org/apache/solr/handler/dataimport/TestTikaEntityProcessor.java (original)
+++ lucene/dev/trunk/solr/contrib/dataimporthandler/src/extras/test/java/org/apache/solr/handler/dataimport/TestTikaEntityProcessor.java Sat Feb 19 01:33:12 2011
@@ -17,6 +17,7 @@
package org.apache.solr.handler.dataimport;
import org.junit.BeforeClass;
+import org.junit.Test;
/**Testcase for TikaEntityProcessor
* @version $Id$
@@ -28,6 +29,7 @@ public class TestTikaEntityProcessor ext
initCore("dataimport-solrconfig.xml", "dataimport-schema-no-unique-key.xml", getFile("solr-dihextras").getAbsolutePath());
}
+ @Test
public void testIndexingWithTikaEntityProcessor() throws Exception {
String conf =
"<dataConfig>" +
@@ -35,12 +37,17 @@ public class TestTikaEntityProcessor ext
" <document>" +
" <entity processor=\"TikaEntityProcessor\" url=\"" + getFile("solr-word.pdf").getAbsolutePath() + "\" >" +
" <field column=\"Author\" meta=\"true\" name=\"author\"/>" +
- " <field column=\"title\" meta=\"true\" name=\"docTitle\"/>" +
+ " <field column=\"title\" meta=\"true\" name=\"title\"/>" +
" <field column=\"text\"/>" +
" </entity>" +
" </document>" +
"</dataConfig>";
runFullImport(conf);
- assertQ(req("*:*"), "//*[@numFound='1']");
+ assertQ(req("*:*")
+ ,"//*[@numFound='1']"
+ ,"//str[@name='author'][.='Grant Ingersoll']"
+ ,"//str[@name='title'][.='solr-word']"
+ ,"//str[@name='text']"
+ );
}
}
Re: svn commit: r1072230 -
/lucene/dev/trunk/solr/contrib/dataimporthandler/src/extras/test/java/org/
apache/solr/handler/dataimport/TestTikaEntityProcessor.java
Posted by Chris Hostetter <ho...@fucit.org>.
: fyi, the problem was only the latter part, @Test is not required by
: the test system if the test method starts with "test" (see
: LuceneTestCaseRunner for details)
Ah ... ok ... my mistake, i didn't see the Test listed in the
console output and assumed it was because of hte missing @Test -- but i
think i was just looking in the wrong place (i was also confused by the
whole "extras" thing so i was probably only running hte main DIH tests at
that time)
-Hoss
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1072230 - /lucene/dev/trunk/solr/contrib/dataimporthandler/src/extras/test/java/org/apache/solr/handler/dataimport/TestTikaEntityProcessor.java
Posted by Robert Muir <rc...@gmail.com>.
On Fri, Feb 18, 2011 at 8:33 PM, <ho...@apache.org> wrote:
> Author: hossman
> Date: Sat Feb 19 01:33:12 2011
> New Revision: 1072230
>
> URL: http://svn.apache.org/viewvc?rev=1072230&view=rev
> Log:
> this test was missing @Test, and wasn't actually checking any fields were added
>
fyi, the problem was only the latter part, @Test is not required by
the test system if the test method starts with "test" (see
LuceneTestCaseRunner for details)
all of our junit tests are actually run as junit 4 tests, but we don't
require the useless @Test, @Before, and @After (just use test*,
setUp(), tearDown() as usual).
You can use @BeforeClass though.
this way we get the benefits of junit 4, without the hassles.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org