You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by GERey <gi...@git.apache.org> on 2015/12/31 04:09:42 UTC
[GitHub] usergrid pull request: Adding tests and fix for duplicate org admi...
GitHub user GERey opened a pull request:
https://github.com/apache/usergrid/pull/454
Adding tests and fix for duplicate org administrators for collection …
…connections. Only service level verification
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/usergrid USERGRID-1187
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/usergrid/pull/454.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #454
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] usergrid pull request: Adding tests and fix for duplicate org admi...
Posted by GERey <gi...@git.apache.org>.
Github user GERey commented on the pull request:
https://github.com/apache/usergrid/pull/454#issuecomment-168240406
https://issues.apache.org/jira/browse/USERGRID-1187
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] usergrid pull request: Adding tests and fix for duplicate org admi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/usergrid/pull/454
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] usergrid pull request: Adding tests and fix for duplicate org admi...
Posted by michaelarusso <gi...@git.apache.org>.
Github user michaelarusso commented on a diff in the pull request:
https://github.com/apache/usergrid/pull/454#discussion_r48671653
--- Diff: stack/services/src/main/java/org/apache/usergrid/management/cassandra/ManagementServiceImpl.java ---
@@ -1608,6 +1608,12 @@ public void addAdminUserToOrganization( UserInfo user, OrganizationInfo organiza
}
EntityManager em = emf.getEntityManager( smf.getManagementAppId() );
+
+ if(em.getCollection(organization.getUuid() ,"users",Query.fromQL( "select * where uuid ="+user.getUuid() ),Level.IDS ).size() >0){
+ logger.trace( "Found value: {} already in collection",user.getName() );
--- End diff --
maybe change to debug level and wrap in if statement for isDebugEnabled ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---