You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/04/15 21:55:53 UTC
[GitHub] [cordova-android] erisu opened a new pull request #1207: chore: update theme to Theme.AppCompat.NoActionBar
erisu opened a new pull request #1207:
URL: https://github.com/apache/cordova-android/pull/1207
### Motivation and Context
Update `AndroidManifest.spec.js` based on comment from this PR: https://github.com/apache/cordova-android/pull/1052#pullrequestreview-636784515
### Description
Changed `Theme.DeviceDefault.NoActionBar` to `Theme.AppCompat.NoActionBar` to match changes from PR https://github.com/apache/cordova-android/pull/1052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on pull request #1207: test(AndroidManifest): update theme to Theme.AppCompat.NoActionBar
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1207:
URL: https://github.com/apache/cordova-android/pull/1207#issuecomment-821008724
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1207?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1207](https://codecov.io/gh/apache/cordova-android/pull/1207?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ddf3402) into [master](https://codecov.io/gh/apache/cordova-android/commit/2a84d7c44ddf5eb169f34a2448915a53d0a30fcd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a84d7c) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1207 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 21 21
Lines 1692 1692
=======================================
Hits 1218 1218
Misses 474 474
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1207?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1207?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2a84d7c...ddf3402](https://codecov.io/gh/apache/cordova-android/pull/1207?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1207: test(AndroidManifest): update theme to Theme.AppCompat.NoActionBar
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1207:
URL: https://github.com/apache/cordova-android/pull/1207#issuecomment-821008724
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1207?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1207](https://codecov.io/gh/apache/cordova-android/pull/1207?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ddf3402) into [master](https://codecov.io/gh/apache/cordova-android/commit/2a84d7c44ddf5eb169f34a2448915a53d0a30fcd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2a84d7c) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1207 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 21 21
Lines 1692 1692
=======================================
Hits 1218 1218
Misses 474 474
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1207?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1207?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2a84d7c...ddf3402](https://codecov.io/gh/apache/cordova-android/pull/1207?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jcesarmobile commented on a change in pull request #1207: test(AndroidManifest): update theme to Theme.AppCompat.NoActionBar
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on a change in pull request #1207:
URL: https://github.com/apache/cordova-android/pull/1207#discussion_r614625987
##########
File path: spec/unit/AndroidManifest.spec.js
##########
@@ -40,7 +40,7 @@ describe('AndroidManifest', () => {
android:supportsRtl="true" android:debuggable="true">
<activity android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale"
android:label="@string/activity_name" android:launchMode="${ACTIVITY_LAUNCH_MODE}"
- android:name="${ACTIVITY_NAME}" android:theme="@android:style/Theme.DeviceDefault.NoActionBar"
+ android:name="${ACTIVITY_NAME}" android:theme="@android:style/Theme.AppCompat.NoActionBar"
Review comment:
The `android:` before style/Theme was also removed
https://github.com/apache/cordova-android/pull/1052/files#diff-964af6e8b782845fe05d5c1c69a192dc4571018c804b1766a7dc9566c9ac6b1aR38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #1207: test(AndroidManifest): update theme to Theme.AppCompat.NoActionBar
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1207:
URL: https://github.com/apache/cordova-android/pull/1207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org