You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by andrewmlim <gi...@git.apache.org> on 2017/05/02 20:20:32 UTC

[GitHub] nifi pull request #1733: NIFI-3701 Documentation improvements for 1.x

GitHub user andrewmlim opened a pull request:

    https://github.com/apache/nifi/pull/1733

    NIFI-3701 Documentation improvements for 1.x

    Admin Guide:
    
    - Corrected/updated access policy tables to better align with UI
    - Split policy tables into one for Global, one for Component
    - Corrected empty authorizations.xml and users.xml cluster usage
    - Updated description for nifi.templates.directory properties description
    - Added note about using List/Delete Queues when clustered
    
    User Guide:
    
    - Added note about Back Pressure defaults
    - Updated "Configure Site-to-Site server NiFi instance" section as it referenced 0.x behavior

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andrewmlim/nifi NIFI-3701

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1733.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1733
    
----
commit e939f9a53c1c4ebbb1460aa543f110e2f5110ad4
Author: Andrew Lim <an...@gmail.com>
Date:   2017-05-02T20:12:58Z

    NIFI-3701 Documentation improvements for 1.x

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1733: NIFI-3701 Documentation improvements for 1.x

Posted by andrewmlim <gi...@git.apache.org>.
Github user andrewmlim commented on the issue:

    https://github.com/apache/nifi/pull/1733
  
    Closing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1733: NIFI-3701 Documentation improvements for 1.x

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/1733
  
    Sorry @andrewmlim I accidentally got a space into the commit message. Can you please close this branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1733: NIFI-3701 Documentation improvements for 1.x

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1733#discussion_r114417950
  
    --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
    @@ -462,30 +462,39 @@ Here is an example entry:
     
     After you have edited and saved the 'authorizers.xml' file, restart NiFi. Users and roles from the 'authorized-users.xml' file are converted and added as identities and policies in the 'users.xml' and 'authorizations.xml' files.  Once the application starts, users who previously had a legacy Administrator role can access the UI and begin managing users, groups, and policies.
     
    -Here is a summary of policies assigned to each legacy role if the NiFi instance has an existing flow.xml.gz:
    +The following tables summarize the global and component policies assigned to each legacy role if the NiFi instance has an existing flow.xml.gz:
    --- End diff --
    
    It appears the standard is to note filenames via a single quote, which makes it italic. Suggest changing `flow.xml.gz` to `'flow.xml.gz'`. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1733: NIFI-3701 Documentation improvements for 1.x

Posted by andrewmlim <gi...@git.apache.org>.
Github user andrewmlim commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1733#discussion_r114418732
  
    --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
    @@ -462,30 +462,39 @@ Here is an example entry:
     
     After you have edited and saved the 'authorizers.xml' file, restart NiFi. Users and roles from the 'authorized-users.xml' file are converted and added as identities and policies in the 'users.xml' and 'authorizations.xml' files.  Once the application starts, users who previously had a legacy Administrator role can access the UI and begin managing users, groups, and policies.
     
    -Here is a summary of policies assigned to each legacy role if the NiFi instance has an existing flow.xml.gz:
    +The following tables summarize the global and component policies assigned to each legacy role if the NiFi instance has an existing flow.xml.gz:
    --- End diff --
    
    Good catch!  Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1733: NIFI-3701 Documentation improvements for 1.x

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1733#discussion_r114417180
  
    --- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc ---
    @@ -834,6 +834,7 @@ image:connection-settings.png["Connection Settings"]
     The Connection name is optional. If not specified, the name shown for the Connection will be names of the Relationships
     that are active for the Connection.
     
    +===== FlowFile Expiration
     File expiration is a concept by which data that cannot be processed in a timely fashion can be automatically removed from the flow.
    --- End diff --
    
    I think the first word here should be *FlowFile* -- *FlowFile expiration is a concept...*. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1733: NIFI-3701 Documentation improvements for 1.x

Posted by andrewmlim <gi...@git.apache.org>.
Github user andrewmlim closed the pull request at:

    https://github.com/apache/nifi/pull/1733


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1733: NIFI-3701 Documentation improvements for 1.x

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/1733
  
    Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1733: NIFI-3701 Documentation improvements for 1.x

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/1733
  
    I will make the two minor fixes above and merge. Thanks @andrewmlim . 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1733: NIFI-3701 Documentation improvements for 1.x

Posted by andrewmlim <gi...@git.apache.org>.
Github user andrewmlim commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1733#discussion_r114417502
  
    --- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc ---
    @@ -834,6 +834,7 @@ image:connection-settings.png["Connection Settings"]
     The Connection name is optional. If not specified, the name shown for the Connection will be names of the Relationships
     that are active for the Connection.
     
    +===== FlowFile Expiration
     File expiration is a concept by which data that cannot be processed in a timely fashion can be automatically removed from the flow.
    --- End diff --
    
    Agreed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1733: NIFI-3701 Documentation improvements for 1.x

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/1733
  
    I ran `contrib-check` and verified that the generated docs look good. Merged to master. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---