You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/04/20 01:26:50 UTC

[GitHub] carbondata pull request #2193: [CARBONDATA-2364][HotFix] Remove useless code...

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2193

    [CARBONDATA-2364][HotFix] Remove useless code in dataloading

    Remove useless and performance related code in dataloading
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [x] Any interfaces changed?
     `NO`
     - [x] Any backward compatibility impacted?
      `NO`
     - [x] Document update required?
     `NO`
     - [x] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
     `NO`
            - How it is tested? Please attach test report.
    `Tested in local`
            - Is it a performance related change? Please attach the performance test report.
    `The code to remove affects the performance, after removing it, performance should gained as described in ` #1953 
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata 0420_bug_remove_range_code

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2193.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2193
    
----
commit 73b409c9486f7d5cfbc7c4d7a25691d9cd2ba009
Author: xuchuanyin <xu...@...>
Date:   2018-04-20T01:21:03Z

    Remove useless code in dataloading

----


---

[GitHub] carbondata issue #2193: [CARBONDATA-2364][HotFix] Remove useless code in dat...

Posted by jackylk <gi...@git.apache.org>.

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2193
  
    LGTM


---

[GitHub] carbondata issue #2193: [CARBONDATA-2364][HotFix] Remove useless code in dat...

Posted by xuchuanyin <gi...@git.apache.org>.

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2193
  
    This PR is a supplement to #1953 


---

[GitHub] carbondata issue #2193: [CARBONDATA-2364][HotFix] Remove useless code in dat...

Posted by xuchuanyin <gi...@git.apache.org>.

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2193
  
    retest this please


---

[GitHub] carbondata pull request #2193: [CARBONDATA-2364][HotFix] Remove useless code...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2193


---

[GitHub] carbondata issue #2193: [CARBONDATA-2364][HotFix] Remove useless code in dat...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2193
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4032/



---

[GitHub] carbondata issue #2193: [CARBONDATA-2364][HotFix] Remove useless code in dat...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2193
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4049/



---