You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/27 18:22:55 UTC

[GitHub] [spark] ueshin commented on a diff in pull request #37305: [SPARK-39881][PYTHON] Fix erroneous check for black and reenable black validation.

ueshin commented on code in PR #37305:
URL: https://github.com/apache/spark/pull/37305#discussion_r931421702


##########
dev/lint-python:
##########
@@ -210,8 +210,8 @@ function black_test {
     local BLACK_STATUS=
 
     # Skip check if black is not installed.
-    $BLACK_BUILD 2> /dev/null
-    if [ $? -ne 0 ]; then
+    $PYTHON_EXECUTABLE -c 'import black' &> /dev/null
+    if [[ $? -ne 0 ]]; then

Review Comment:
   Shall we revert it then? At least could you make them consistent?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org