You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/01 14:17:26 UTC

[GitHub] [flink] akalash opened a new pull request, #19865: [FLINK-26993][tests] Wait until checkpoint was actually triggered

akalash opened a new pull request, #19865:
URL: https://github.com/apache/flink/pull/19865

   
   
   ## What is the purpose of the change
   
   Backport to release-1.15 of https://github.com/apache/flink/pull/19356
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] akalash commented on pull request #19865: [FLINK-26993][tests] Wait until checkpoint was actually triggered

Posted by GitBox <gi...@apache.org>.
akalash commented on PR #19865:
URL: https://github.com/apache/flink/pull/19865#issuecomment-1150671595

   @pnowojski ,You can check logs from this ticket for example - https://issues.apache.org/jira/browse/FLINK-27216(it is a fresh duplicate of FLINK-26993). There is a pretty clear NPE exception(https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=34535&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8&l=9180) which happens because we call `receiveAcknowledgeMessage` before the `PendingCheckpoint` was initialized(it happens only in test since we trigger it manually but it is an impossible situation in reality). It was broken when we separate setting checkpoint storage from creating of the PendingCheckpoint.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] akalash commented on pull request #19865: [FLINK-26993][tests] Wait until checkpoint was actually triggered

Posted by GitBox <gi...@apache.org>.
akalash commented on PR #19865:
URL: https://github.com/apache/flink/pull/19865#issuecomment-1154843461

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #19865: [FLINK-26993][tests] Wait until checkpoint was actually triggered

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19865:
URL: https://github.com/apache/flink/pull/19865#issuecomment-1143675821

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cdc7a3708a367fd4b67ddba9a725a306287d09a1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cdc7a3708a367fd4b67ddba9a725a306287d09a1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cdc7a3708a367fd4b67ddba9a725a306287d09a1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] pnowojski commented on pull request #19865: [FLINK-26993][tests] Wait until checkpoint was actually triggered

Posted by GitBox <gi...@apache.org>.
pnowojski commented on PR #19865:
URL: https://github.com/apache/flink/pull/19865#issuecomment-1150092538

   Change LGTM, but I couldn't figure out what has happened in this test failure. I can not figure out which test has failed, am I missing something obvious? I see this being logged:
   ```
   Jun 01 22:02:55 [ERROR] pure virtual method called
   Jun 01 22:02:55 [ERROR] terminate called without an active exception
   Jun 01 22:02:59 [ERROR] Aborted (core dumped)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] pnowojski merged pull request #19865: [FLINK-26993][tests] Wait until checkpoint was actually triggered

Posted by GitBox <gi...@apache.org>.
pnowojski merged PR #19865:
URL: https://github.com/apache/flink/pull/19865


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org