You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/12/02 22:21:13 UTC
[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #2835: GOBBLIN-989: Track and report record level SLA in Gobblin Kafka Extra…
ZihanLi58 commented on a change in pull request #2835: GOBBLIN-989: Track and report record level SLA in Gobblin Kafka Extra…
URL: https://github.com/apache/incubator-gobblin/pull/2835#discussion_r352888340
##########
File path: gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaExtractor.java
##########
@@ -176,7 +176,12 @@ public D readRecordImpl(D reuse) throws DataRecordException, IOException {
D record = decodeKafkaMessage(nextValidMessage);
- this.statsTracker.onDecodeableRecord(this.currentPartitionIdx, readStartTime, decodeStartTime, nextValidMessage.getValueSizeInBytes());
+ long logAppendTime = 0L;
+ if (nextValidMessage.isTimestampLogAppend()) {
Review comment:
If this means we only enable SLA when the record timestamp type is LogAppendTime. And when it's CreateTime we do not track the SLA?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services