You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/06/23 13:23:16 UTC
[GitHub] [carbondata] maheshrajus opened a new pull request #4163: [WIP] table properties not updated with lower-case
maheshrajus opened a new pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163
### Why is this PR needed?
todo
### What changes were proposed in this PR?
todo
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
### Is any new testcase added?
- No
- Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869755368
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-868350850
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5633/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-867921854
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/35/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869661252
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5643/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on a change in pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on a change in pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#discussion_r657860282
##########
File path: integration/spark/src/main/common2.3and2.4/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
##########
@@ -25,7 +25,7 @@ import org.apache.spark.sql.catalyst.parser.SqlBaseParser._
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
import org.apache.spark.sql.execution.{SparkSqlAstBuilder, SparkSqlParser}
import org.apache.spark.sql.internal.{SQLConf, VariableSubstitution}
-import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.needToConvertToLowerCase
+import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.{convertPropertiesToLowercase, needToConvertToLowerCase}
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-870454406
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-867258625
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/27/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#discussion_r657711504
##########
File path: integration/spark/src/main/common2.3and2.4/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
##########
@@ -25,7 +25,7 @@ import org.apache.spark.sql.catalyst.parser.SqlBaseParser._
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
import org.apache.spark.sql.execution.{SparkSqlAstBuilder, SparkSqlParser}
import org.apache.spark.sql.internal.{SQLConf, VariableSubstitution}
-import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.needToConvertToLowerCase
+import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.{convertPropertiesToLowercase, needToConvertToLowerCase}
Review comment:
remove unused import
##########
File path: integration/spark/src/main/spark3.1/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
##########
@@ -25,6 +25,8 @@ import org.apache.spark.sql.catalyst.parser.SqlBaseParser._
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
import org.apache.spark.sql.execution.{SparkSqlAstBuilder, SparkSqlParser}
import org.apache.spark.sql.internal.{SQLConf, VariableSubstitution}
+import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.convertPropertiesToLowercase
+import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.needToConvertToLowerCase
Review comment:
remove unsued import
##########
File path: integration/spark/src/main/spark3.1/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
##########
@@ -25,6 +25,8 @@ import org.apache.spark.sql.catalyst.parser.SqlBaseParser._
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
import org.apache.spark.sql.execution.{SparkSqlAstBuilder, SparkSqlParser}
import org.apache.spark.sql.internal.{SQLConf, VariableSubstitution}
+import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.convertPropertiesToLowercase
+import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.needToConvertToLowerCase
Review comment:
remove unused import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-867606567
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5630/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-867498935
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/31/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#discussion_r660299614
##########
File path: integration/spark/src/main/spark3.1/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
##########
@@ -127,8 +128,14 @@ class CarbonHelperSqlAstBuilder(conf: SQLConf,
val tableProperties = mutable.Map[String, String]()
val properties: Map[String, String] = getPropertyKeyValues(tablePropertyList)
- properties.foreach{property => tableProperties.put(property._1, property._2)}
+ properties.foreach { property =>
Review comment:
please move this to common util and reuse
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-870454406
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869870214
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/48/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#discussion_r660299614
##########
File path: integration/spark/src/main/spark3.1/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
##########
@@ -127,8 +128,14 @@ class CarbonHelperSqlAstBuilder(conf: SQLConf,
val tableProperties = mutable.Map[String, String]()
val properties: Map[String, String] = getPropertyKeyValues(tablePropertyList)
- properties.foreach{property => tableProperties.put(property._1, property._2)}
+ properties.foreach { property =>
Review comment:
please move this to common util and reuse
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-870555206
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/52/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869755368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-868348991
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/37/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-867919154
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5631/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869859278
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5644/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869873704
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [WIP] table properties not updated with lower-case
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-867043719
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/26/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-867189321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-867599496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-867498665
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3884/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-870391117
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3903/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869974164
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5645/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-867259527
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5623/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869460069
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/42/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-870540281
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5648/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869363901
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-870732670
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869993371
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/49/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869661252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869449385
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5638/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869666271
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/47/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-868332012
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3890/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] ydvpankaj99 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
ydvpankaj99 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-868257127
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-870389785
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5646/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-867915274
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3888/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-867254964
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3880/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869453714
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3895/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869663389
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3900/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869981868
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3902/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869862742
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3901/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-869576177
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-870392848
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/50/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-867496764
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5627/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] maheshrajus commented on a change in pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
maheshrajus commented on a change in pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#discussion_r657861734
##########
File path: integration/spark/src/main/spark3.1/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
##########
@@ -25,6 +25,8 @@ import org.apache.spark.sql.catalyst.parser.SqlBaseParser._
import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
import org.apache.spark.sql.execution.{SparkSqlAstBuilder, SparkSqlParser}
import org.apache.spark.sql.internal.{SQLConf, VariableSubstitution}
+import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.convertPropertiesToLowercase
+import org.apache.spark.sql.parser.CarbonSparkSqlParserUtil.needToConvertToLowerCase
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4163: [CARBONDATA-4230] table properties not updated with lower-case and table comment not working in carbon spark 3.1
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4163:
URL: https://github.com/apache/carbondata/pull/4163#issuecomment-870541994
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3905/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org