You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/12/18 00:27:41 UTC

[GitHub] spark pull request #20005: [DO-NOT-MERGE] Investigating SparkR test failure

GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/20005

    [DO-NOT-MERGE] Investigating SparkR test failure

    ## What changes were proposed in this pull request?
    
    Don't merge this. I would like to check few things. I am super busy for the rest of this month so I wouldn't make it shortly.
    
    Please keep investigating this if anyone is doing.
    
    ## How was this patch tested?
    
    N/A

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark investigating-cran

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20005.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20005
    
----
commit 6646eb56431fd5cd54c0c6342fca69428a2d51e0
Author: hyukjinkwon <gu...@gmail.com>
Date:   2017-12-18T00:23:26Z

    R change

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20005: [DO-NOT-MERGE] Investigating SparkR test failure

Posted by viirya <gi...@git.apache.org>.

Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/20005
  
    Verified locally, this issue fixed. Let's wait for Jenkins.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20005: [DO-NOT-MERGE] Investigating SparkR test failure

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/20005
  
    @viirya you are my hero.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20005: [DO-NOT-MERGE] Investigating SparkR test failure

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/20005
  
    Just checked it passes with R 3.1.1 in my local too!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20005: [DO-NOT-MERGE] Investigating SparkR test failure

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20005
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20005: [DO-NOT-MERGE] Investigating SparkR test failure

Posted by viirya <gi...@git.apache.org>.

Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/20005
  
    Oh, Thanks for cran sysadmin team's quick reply, they fixed that broken page.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20005: [DO-NOT-MERGE] Investigating SparkR test failure

Posted by viirya <gi...@git.apache.org>.

Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/20005
  
    Note: I've emailed to cran sysadmin team and asked them for help to fix the broken page.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20005: [DO-NOT-MERGE] Investigating SparkR test failure

Posted by viirya <gi...@git.apache.org>.

Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/20005
  
    I've tried to investigate this and I think it is due to a wrongly formatted document at https://cran.r-project.org/src/contrib/PACKAGES.in:
    
    ```
    Package: alR
    X-CRAN-Comment: Archived again on 2017-12-15 as none of the errors (failure to install with clang and on Solaris, buffer overflows) were corrected.
    
    X-CRAN-History: Archived on 2017-12-01 as C++ errors (and segfaults) were not corrected despite reminders.
    	Unarchived on 2017-12-07.
    ```
    
    There is an additional breaking line here and it breaks the function `tools:::.check_package_CRAN_incoming`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org