[jira] [Commented] (CASSANDRA-11968) More metrics on native protocol requests & responses

["Sam Tunnicliffe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346497#comment-15346497 ] 

Sam Tunnicliffe commented on CASSANDRA-11968:
---------------------------------------------

I was initially sceptical about a new {{TransportMetrics}} class rather just adding metrics to {{ClientMetrics}}. I presume that the reasoning is to make it clear that the new metrics don't include Thrift connections, is that right? If so, perhaps we should duplicate {{ClientMetrics::connectedNativeClients}} in {{TransportMetrics}} (perhaps with a slight name change) and deprecate {{ClientMetrics}} entirely.

What impact do you anticipate the updating of the counters in {{TransportMetrics}} to have? Obviously, this is very much on a hot path so it would be good to get some measurements from cstar-perf about the effects of contention there before proceeding.


> More metrics on native protocol requests & responses
> ----------------------------------------------------
>
>                 Key: CASSANDRA-11968
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11968
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>            Priority: Minor
>             Fix For: 3.x
>
>
> Proposal to add more metrics to the native protocol:
> - number of requests per request-type
> - number of responses by response-type
> - size of request messages in bytes
> - size of response messages in bytes
> - number of in-flight requests (from request arrival to response)
> (Will provide a patch soon)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)