[GitHub] [dolphinscheduler] Radeity commented on a diff in pull request #13206: [improve-#13201] update pid during running

["Radeity (via GitHub)" <gi...@apache.org>]

Radeity commented on code in PR #13206:
URL: https://github.com/apache/dolphinscheduler/pull/13206#discussion_r1335352297


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/processor/queue/TaskEvent.java:
##########
@@ -161,4 +162,16 @@ public static TaskEvent newCacheEvent(int processInstanceId, int taskInstanceId,
         event.setEvent(TaskEventType.CACHE);
         return event;
     }
+
+    public static TaskEvent newUpdatePidEvent(TaskUpdatePidCommand command, Channel channel, String workerAddress) {
+        TaskEvent event = new TaskEvent();
+        event.setProcessInstanceId(command.getProcessInstanceId());
+        event.setTaskInstanceId(command.getTaskInstanceId());
+        event.setStartTime(DateUtils.timeStampToDate(command.getStartTime()));
+        event.setLogPath(command.getLogPath());
+        event.setChannel(channel);
+        event.setWorkerAddress(workerAddress);
+        event.setEvent(TaskEventType.UPDATE_PID);
+        return event;
+    }

Review Comment:
   Did you forget to `setProcessId` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org