You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/21 01:28:05 UTC
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4666: Support v3 extension header
wu-sheng commented on a change in pull request #4666:
URL: https://github.com/apache/skywalking/pull/4666#discussion_r411799547
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java
##########
@@ -53,7 +53,7 @@ public void extract(ContextCarrier carrier) {
@Override
public ContextSnapshot capture() {
- return new ContextSnapshot(null, -1, null, null, correlationContext);
+ return new ContextSnapshot(null, -1, null, null, correlationContext, new ExtensionContext());
Review comment:
`#capture` should propogate the `ExtensionContext`, rather than creating a new one.
##########
File path: test/plugin/scenarios/apm-toolkit-trace-scenario/configuration.yml
##########
@@ -18,3 +18,8 @@ type: jvm
entryService: http://localhost:8080/apm-toolkit-trace-scenario/case/tool-kit
healthCheck: http://localhost:8080/apm-toolkit-trace-scenario/case/healthCheck
startScript: ./bin/startup.sh
+extendEntryHeader:
Review comment:
Is this config for injecting headers?
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java
##########
@@ -53,7 +53,7 @@ public void extract(ContextCarrier carrier) {
@Override
public ContextSnapshot capture() {
- return new ContextSnapshot(null, -1, null, null, correlationContext);
+ return new ContextSnapshot(null, -1, null, null, correlationContext, new ExtensionContext());
Review comment:
I can see it is inside the tracing context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org