You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org> on 2025/11/26 13:41:56 UTC
[PR] [fix](ann index) fix omp threads limit can not be assigned manually [doris]
zhiqiang-hhhh opened a new pull request, #58427:
URL: https://github.com/apache/doris/pull/58427
### What problem does this PR solve?
Make sure user specified omp_threads_limit is working.
Related PR: https://github.com/apache/doris/pull/56796
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ann index) fix omp threads limit can not be assigned manually [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon merged PR #58427:
URL: https://github.com/apache/doris/pull/58427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ann index) fix omp threads limit can not be assigned manually [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58427:
URL: https://github.com/apache/doris/pull/58427#issuecomment-3582106868
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58427_708b4caec9e3d855d43dc2d4b39e1968141487df_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58427_708b4caec9e3d855d43dc2d4b39e1968141487df_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.65% (24522/34225) |
| Line Coverage | 58.14% (255374/439277) |
| Region Coverage | 53.24% (212796/399710) |
| Branch Coverage | 54.69% (90819/166054) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ann index) fix omp threads limit can not be assigned manually [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #58427:
URL: https://github.com/apache/doris/pull/58427#issuecomment-3581379326
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ann index) fix omp threads limit can not be assigned manually [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58427:
URL: https://github.com/apache/doris/pull/58427#issuecomment-3587715575
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ann index) fix omp threads limit can not be assigned manually [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58427:
URL: https://github.com/apache/doris/pull/58427#issuecomment-3581592289
<details>
<summary>TPC-DS: <b>Total hot run time: 184026 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 708b4caec9e3d855d43dc2d4b39e1968141487df, data reload: false
query1 1110 398 380 380
query2 6555 1600 1559 1559
query3 6750 221 215 215
query4 25353 22682 23054 22682
query5 5360 643 481 481
query6 326 227 226 226
query7 4654 489 292 292
query8 295 251 240 240
query9 8727 2554 2552 2552
query10 563 358 302 302
query11 14971 14702 14454 14454
query12 175 115 111 111
query13 1686 575 451 451
query14 10591 8876 8824 8824
query15 219 208 190 190
query16 7387 691 497 497
query17 1209 739 617 617
query18 2006 419 324 324
query19 206 203 168 168
query20 126 125 116 116
query21 226 134 113 113
query22 4059 4040 4199 4040
query23 32865 32099 32036 32036
query24 8415 2385 2378 2378
query25 593 509 479 479
query26 1242 269 162 162
query27 2767 486 336 336
query28 4415 2130 2113 2113
query29 802 607 474 474
query30 302 240 213 213
query31 828 727 618 618
query32 87 70 74 70
query33 591 379 324 324
query34 794 875 526 526
query35 807 832 752 752
query36 911 941 817 817
query37 127 109 87 87
query38 3306 3367 3280 3280
query39 1464 1436 1378 1378
query40 227 130 121 121
query41 64 62 63 62
query42 130 111 120 111
query43 438 455 435 435
query44 1242 753 739 739
query45 199 183 183 183
query46 885 982 639 639
query47 1718 1738 1696 1696
query48 399 414 334 334
query49 774 493 419 419
query50 643 687 396 396
query51 3868 3981 3819 3819
query52 112 109 107 107
query53 245 257 191 191
query54 302 293 272 272
query55 102 94 92 92
query56 328 320 307 307
query57 1154 1214 1143 1143
query58 284 276 275 275
query59 2498 2462 2378 2378
query60 372 356 350 350
query61 192 186 207 186
query62 763 720 661 661
query63 226 195 192 192
query64 4639 1313 997 997
query65 4024 3987 4017 3987
query66 1157 455 354 354
query67 15164 15066 14754 14754
query68 8340 897 633 633
query69 545 348 323 323
query70 1341 1199 1273 1199
query71 467 333 317 317
query72 5927 4879 4907 4879
query73 644 608 351 351
query74 8629 8826 8663 8663
query75 3806 3325 2804 2804
query76 3562 1126 707 707
query77 830 404 297 297
query78 9573 9809 8898 8898
query79 2016 833 587 587
query80 649 587 487 487
query81 496 272 243 243
query82 452 167 133 133
query83 266 269 253 253
query84 261 118 96 96
query85 869 475 440 440
query86 341 308 298 298
query87 3596 3575 3387 3387
query88 3614 2241 2248 2241
query89 393 322 288 288
query90 1969 220 208 208
query91 164 169 139 139
query92 85 72 63 63
query93 1180 978 654 654
query94 744 436 333 333
query95 499 402 385 385
query96 495 563 277 277
query97 2926 2924 2870 2870
query98 235 208 205 205
query99 1308 1412 1291 1291
Total cold run time: 271241 ms
Total hot run time: 184026 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ann index) fix omp threads limit can not be assigned manually [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58427:
URL: https://github.com/apache/doris/pull/58427#issuecomment-3581613696
<details>
<summary>ClickBench: <b>Total hot run time: 27.31 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 708b4caec9e3d855d43dc2d4b39e1968141487df, data reload: false
query1 0.06 0.05 0.05
query2 0.10 0.05 0.05
query3 0.26 0.08 0.08
query4 1.61 0.12 0.11
query5 0.28 0.26 0.26
query6 1.16 0.65 0.64
query7 0.04 0.03 0.03
query8 0.05 0.04 0.05
query9 0.58 0.53 0.51
query10 0.58 0.57 0.57
query11 0.16 0.10 0.11
query12 0.15 0.12 0.12
query13 0.63 0.61 0.59
query14 1.00 1.00 0.99
query15 0.85 0.82 0.83
query16 0.40 0.39 0.38
query17 1.05 0.98 1.07
query18 0.21 0.19 0.20
query19 1.91 1.79 1.78
query20 0.01 0.02 0.02
query21 15.47 0.19 0.13
query22 5.03 0.06 0.05
query23 15.68 0.27 0.10
query24 2.60 0.57 1.12
query25 0.07 0.08 0.05
query26 0.14 0.13 0.14
query27 0.06 0.05 0.05
query28 5.24 1.17 0.93
query29 12.60 3.89 3.21
query30 0.28 0.14 0.11
query31 2.81 0.60 0.39
query32 3.23 0.55 0.46
query33 3.00 3.08 2.99
query34 15.91 5.14 4.49
query35 4.53 4.54 4.52
query36 0.66 0.50 0.48
query37 0.10 0.06 0.08
query38 0.05 0.05 0.04
query39 0.03 0.02 0.02
query40 0.18 0.15 0.14
query41 0.09 0.04 0.03
query42 0.04 0.02 0.03
query43 0.04 0.04 0.03
Total cold run time: 98.93 s
Total hot run time: 27.31 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ann index) fix omp threads limit can not be assigned manually [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58427:
URL: https://github.com/apache/doris/pull/58427#issuecomment-3581540370
<details>
<summary>TPC-H: <b>Total hot run time: 34556 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 708b4caec9e3d855d43dc2d4b39e1968141487df, data reload: false
------ Round 1 ----------------------------------
q1 17599 5077 4910 4910
q2 2046 321 204 204
q3 10232 1271 731 731
q4 10216 847 356 356
q5 7536 2292 2360 2292
q6 189 172 137 137
q7 927 799 626 626
q8 9346 1331 1051 1051
q9 7103 5353 5400 5353
q10 6871 2217 1808 1808
q11 503 290 279 279
q12 347 362 225 225
q13 18450 3620 3130 3130
q14 242 271 229 229
q15 577 507 512 507
q16 1032 1035 982 982
q17 618 897 381 381
q18 7611 7287 7302 7287
q19 1118 957 561 561
q20 360 342 232 232
q21 3923 2526 2321 2321
q22 1049 1011 954 954
Total cold run time: 107895 ms
Total hot run time: 34556 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4958 4962 4927 4927
q2 332 398 306 306
q3 2176 2656 2275 2275
q4 1318 1743 1299 1299
q5 4221 4415 4522 4415
q6 215 179 145 145
q7 2046 1917 1848 1848
q8 2620 2596 2499 2499
q9 7452 7567 7460 7460
q10 3089 3273 2791 2791
q11 593 524 509 509
q12 692 770 583 583
q13 3679 3920 3291 3291
q14 299 320 279 279
q15 542 512 494 494
q16 1052 1124 1070 1070
q17 1330 1600 1368 1368
q18 7697 7719 7494 7494
q19 829 781 828 781
q20 1985 1974 1820 1820
q21 4715 4460 4254 4254
q22 1097 1060 1024 1024
Total cold run time: 52937 ms
Total hot run time: 50932 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ann index) fix omp threads limit can not be assigned manually [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #58427:
URL: https://github.com/apache/doris/pull/58427#issuecomment-3581379839
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ann index) fix omp threads limit can not be assigned manually [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58427:
URL: https://github.com/apache/doris/pull/58427#issuecomment-3581677434
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/708b4caec9e3d855d43dc2d4b39e1968141487df_708b4caec9e3d855d43dc2d4b39e1968141487df/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/708b4caec9e3d855d43dc2d4b39e1968141487df_708b4caec9e3d855d43dc2d4b39e1968141487df/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.85% (18448/34906) |
| Line Coverage | 38.37% (168718/439662) |
| Region Coverage | 33.17% (130989/394896) |
| Branch Coverage | 34.15% (56393/165157) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](ann index) fix omp threads limit can not be assigned manually [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58427:
URL: https://github.com/apache/doris/pull/58427#issuecomment-3587715507
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org