You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jl...@apache.org on 2026/10/03 08:29:15 UTC

(superset) branch ultraset-mh-chart-import-uuid-in-2 updated: fix(mypy): drop drift-prone line reference in Slice.uuid ignore comment

This is an automated email from the ASF dual-hosted git repository.

sadpandajoe pushed a commit to branch ultraset-mh-chart-import-uuid-in-2
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/ultraset-mh-chart-import-uuid-in-2 by this push:
     new 64e6b2962e1 fix(mypy): drop drift-prone line reference in Slice.uuid ignore comment
64e6b2962e1 is described below

commit 64e6b2962e1d90e27d619d824b2696e722b67309
Author: Joe Li <47...@users.noreply.github.com>
AuthorDate: Sat Oct 3 08:29:01 2026 +0000

    fix(mypy): drop drift-prone line reference in Slice.uuid ignore comment
    
    The cross-reference named a specific line in dataset_scope.py. The
    equivalent pre-existing reference it mirrors already rotted (it points
    at a stray closing brace), so name the file only.
    
    Co-Authored-By: Claude Opus 5 <no...@anthropic.com>
---
 superset/commands/chart/importers/v1/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/commands/chart/importers/v1/__init__.py b/superset/commands/chart/importers/v1/__init__.py
index 69779de61a7..e5528e0df5f 100644
--- a/superset/commands/chart/importers/v1/__init__.py
+++ b/superset/commands/chart/importers/v1/__init__.py
@@ -163,7 +163,7 @@ class ImportChartsCommand(ImportModelsCommand):
                     # chain, so in a full-repo mypy run mypy resolves it through
                     # CoreChart's plain `uuid: UUID | None` annotation instead of
                     # the Column descriptor; same false positive already ignored
-                    # at superset/mcp_service/dataset_scope.py:131.
+                    # in superset/mcp_service/dataset_scope.py.
                     Slice.uuid.in_(dependency_chart_uuids)  # type: ignore[union-attr]
                 )
             }