You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by harishreedharan <gi...@git.apache.org> on 2015/02/01 02:51:32 UTC

[GitHub] spark pull request: [SPARK-3778] newAPIHadoopRDD doesn't properly ...

Github user harishreedharan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4292#discussion_r23893987
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -820,7 +822,10 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli
           kClass: Class[K],
           vClass: Class[V]): RDD[(K, V)] = {
         assertNotStopped()
    -    new NewHadoopRDD(this, fClass, kClass, vClass, conf)
    +    // Add necessary security credentials to the JobConf. Required to access secure HDFS.
    +    val jconf = new JobConf(conf)
    +    SparkHadoopUtil.get.addCredentials(jconf)
    --- End diff --
    
    Since security is supported only in Yarn mode, this should be fine. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org