[GitHub] spark pull request: [SPARK-9695] [ML] Add random seed Param to ML ...

[holdenk <gi...@git.apache.org>]

Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9158#discussion_r57759943
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
    @@ -100,6 +101,15 @@ class Pipeline(override val uid: String) extends Estimator[PipelineModel] {
       /** @group getParam */
       def getStages: Array[PipelineStage] = $(stages).clone()
     
    +  /** @group setParam */
    --- End diff --
    
    Probably worth it to include some Javadoc which explains how setSeed works (e.g. it seems to set the seed on all elements which haveSeed but are not set but a user might assume it overwrites the previous values).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org