You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by randerzander <gi...@git.apache.org> on 2015/09/19 23:55:31 UTC
[GitHub] storm pull request: STORM-1055
GitHub user randerzander opened a pull request:
https://github.com/apache/storm/pull/748
STORM-1055
Fixed README by adding note about com.google.common.collect class usage, also fixed hikariConfigMap reference in example.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/randerzander/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/748.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #748
----
commit 2bda1af3656351aa08524ec3e1824f2a8ed62b6e
Author: Randy Gelhausen <rg...@gmail.com>
Date: 2015-09-19T21:52:29Z
Added note about use of com.google.common.collect classes, corrected "map" to "hikariConfigMap" in examples
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1055
Posted by randerzander <gi...@git.apache.org>.
Github user randerzander commented on the pull request:
https://github.com/apache/storm/pull/748#issuecomment-141844499
Unfortunately I missed an additional map->hikariConfigMap example further down the README. Also, this applies to the 0.10.x branch as well. Is it possible to merge there too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1055
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/748#issuecomment-141839836
You don't need to consider about Travis CI since you modifies only markdown file.
It's due to random test failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1055
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/748#discussion_r39935249
--- Diff: external/storm-jdbc/README.md ---
@@ -3,14 +3,16 @@ Storm/Trident integration for JDBC. This package includes the core bolts and tri
to either insert storm tuples in a database table or to execute select queries against a database and enrich tuples
in a storm topology.
+**Note**: Throughout the examples below, we make use of com.google.common.collect.Lists and com.google.common.collect.Maps.
+
## Inserting into a database.
The bolt and trident state included in this package for inserting data into a database tables are tied to a single table.
### ConnectionProvider
-An interface that should be implemented by different connection pooling mechanism `org.apache.storm.jdbc.common.ConnectionProvider`
+An interface that should be implemented by different connection pooling mechanism `org.apache.storm.jdbc.common.ConnectionPrvoider`
```java
-public interface ConnectionProvider extends Serializable {
+public interface ConnectionPrvoider extends Serializable {
--- End diff --
Again, ConnectionProvider is correct, so it shouldn't be changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1055
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/748#issuecomment-141840670
+1.
Since it modifies only doc., I'll merge into master right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1055
Posted by randerzander <gi...@git.apache.org>.
Github user randerzander commented on the pull request:
https://github.com/apache/storm/pull/748#issuecomment-141827482
Not sure why the CI build failed, as I only modified the storm-jdbc README..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1055
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/748#discussion_r39935246
--- Diff: external/storm-jdbc/README.md ---
@@ -3,14 +3,16 @@ Storm/Trident integration for JDBC. This package includes the core bolts and tri
to either insert storm tuples in a database table or to execute select queries against a database and enrich tuples
in a storm topology.
+**Note**: Throughout the examples below, we make use of com.google.common.collect.Lists and com.google.common.collect.Maps.
+
## Inserting into a database.
The bolt and trident state included in this package for inserting data into a database tables are tied to a single table.
### ConnectionProvider
-An interface that should be implemented by different connection pooling mechanism `org.apache.storm.jdbc.common.ConnectionProvider`
+An interface that should be implemented by different connection pooling mechanism `org.apache.storm.jdbc.common.ConnectionPrvoider`
--- End diff --
ConnectionProvider is correct, so it shouldn't be changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1055
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/748
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1055
Posted by randerzander <gi...@git.apache.org>.
Github user randerzander commented on a diff in the pull request:
https://github.com/apache/storm/pull/748#discussion_r39935407
--- Diff: external/storm-jdbc/README.md ---
@@ -3,14 +3,16 @@ Storm/Trident integration for JDBC. This package includes the core bolts and tri
to either insert storm tuples in a database table or to execute select queries against a database and enrich tuples
in a storm topology.
+**Note**: Throughout the examples below, we make use of com.google.common.collect.Lists and com.google.common.collect.Maps.
+
## Inserting into a database.
The bolt and trident state included in this package for inserting data into a database tables are tied to a single table.
### ConnectionProvider
-An interface that should be implemented by different connection pooling mechanism `org.apache.storm.jdbc.common.ConnectionProvider`
+An interface that should be implemented by different connection pooling mechanism `org.apache.storm.jdbc.common.ConnectionPrvoider`
--- End diff --
I cloned from master, not sure where this change came from. Corrected in the next commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1055
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/748#issuecomment-141844867
@randerzander
Please request another PR with same title. Please leave a reminder to new PR so that I can take care of merging into 0.10.x-branch at that time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---