You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/12 14:17:10 UTC

[GitHub] [shardingsphere] zhfeng opened a new issue #13007: Support all the jdbc urls for H2 databases

zhfeng opened a new issue #13007:
URL: https://github.com/apache/shardingsphere/issues/13007


   ## Feature Request
   
   ### Is your feature request related to a problem?
   Currently the [H2DataSourceMetaData](https://github.com/apache/shardingsphere/blob/master/shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/database/metadata/dialect/H2DataSourceMetaData.java#L43) only supports the memory jdbc url like ```jdbc:h2:mem```. While I'm workong with [quarkus-shardingsphere-jdbc](https://github.com/quarkiverse/quarkus-shardingsphere-jdbc), it needs to support all the [H2 jdbc urls ](https://quarkus.io/guides/datasource#h2)
   
   ```
   jdbc:h2:{ {.|mem:}[name] | [file:]fileName | {tcp|ssl}:[//]server[:port][,server2[:port]]/name }[;key=value…​]
   ```
   ### Describe the feature you would like.
   
   It could be great to support all of these urls.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] sandynz closed issue #13007: Support all the jdbc urls for H2 databases

Posted by GitBox <gi...@apache.org>.
sandynz closed issue #13007:
URL: https://github.com/apache/shardingsphere/issues/13007






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] sandynz closed issue #13007: Support all the jdbc urls for H2 databases

Posted by GitBox <gi...@apache.org>.
sandynz closed issue #13007:
URL: https://github.com/apache/shardingsphere/issues/13007


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] zhfeng commented on issue #13007: Support all the jdbc urls for H2 databases

Posted by GitBox <gi...@apache.org>.
zhfeng commented on issue #13007:
URL: https://github.com/apache/shardingsphere/issues/13007#issuecomment-966012869


   @lichengxin813 Well done ! I will check it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] sandynz commented on issue #13007: Support all the jdbc urls for H2 databases

Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #13007:
URL: https://github.com/apache/shardingsphere/issues/13007#issuecomment-961869177


   There might be a little refactoring to do, I'll check it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] sandynz commented on issue #13007: Support all the jdbc urls for H2 databases

Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #13007:
URL: https://github.com/apache/shardingsphere/issues/13007#issuecomment-941880637


   Hi @zhfeng , thanks for you feedback, you've found the cause, would you like to raise a PR to get it done?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] sandynz commented on issue #13007: Support all the jdbc urls for H2 databases

Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #13007:
URL: https://github.com/apache/shardingsphere/issues/13007#issuecomment-966010713


   @lichengxin813 Thank you for your PRs. Welcome to go ahead further.
   
   @zhfeng it's done, you could verify it on master branch or later release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] sandynz commented on issue #13007: Support all the jdbc urls for H2 databases

Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #13007:
URL: https://github.com/apache/shardingsphere/issues/13007#issuecomment-941880637


   Hi @zhfeng , thanks for you feedback, you've found the cause, would you like to raise a PR to get it done?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] sandynz commented on issue #13007: Support all the jdbc urls for H2 databases

Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #13007:
URL: https://github.com/apache/shardingsphere/issues/13007#issuecomment-961869177


   There might be a little refactoring to do, I'll check it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] sandynz commented on issue #13007: Support all the jdbc urls for H2 databases

Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #13007:
URL: https://github.com/apache/shardingsphere/issues/13007#issuecomment-961869177


   There might be a little refactoring to do, I'll check it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org