[jira] Issue Comment Edited: (TIKA-482) Refactor image and jpeg parsers for access to MetadataExtractor API

["Staffan Olsson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TIKA-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906370#action_12906370 ] 

Staffan Olsson edited comment on TIKA-482 at 9/6/10 12:42 AM:
--------------------------------------------------------------

I see the difference in date now:

         assertEquals("Date/Time Original for when the photo was taken, unspecified time zone",
-                "2009-08-11T09:09:45", metadata.get(Metadata.DATE));
+                "2009-08-11T09:09:45", metadata.get(Metadata.ORIGINAL_DATE));
         assertEquals("This image has different Date/Time than Date/Time Original, so it is probably modification date",
-                "2009-10-02T23:02:49", metadata.get(Metadata.LAST_MODIFIED));
+                "2009-10-02T23:02:49", metadata.get(Metadata.DATE));

I don't agree to this change, because the javadocs of DublinCore.DATE say "Typically, Date will be associated with the creation or availability of the resource".

      was (Author: solsson):
    I see the difference in date now:

         assertEquals("Date/Time Original for when the photo was taken, unspecified time zone",
-                "2009-08-11T09:09:45", metadata.get(Metadata.ORIGINAL_DATE));
+                "2009-08-11T09:09:45", metadata.get(Metadata.DATE));
         assertEquals("This image has different Date/Time than Date/Time Original, so it is probably modification date",
-                "2009-10-02T23:02:49", metadata.get(Metadata.DATE));
+                "2009-10-02T23:02:49", metadata.get(Metadata.LAST_MODIFIED));

I don't agree to this change, because the javadocs of DublinCore.DATE say "Typically, Date will be associated with the creation or availability of the resource".
  
> Refactor image and jpeg parsers for access to MetadataExtractor API
> -------------------------------------------------------------------
>
>                 Key: TIKA-482
>                 URL: https://issues.apache.org/jira/browse/TIKA-482
>             Project: Tika
>          Issue Type: Improvement
>          Components: parser
>    Affects Versions: 0.7
>            Reporter: Staffan Olsson
>         Attachments: TIKA-451-DublinCore_and_TIKA-482.patch
>
>
> When I added support for more image metadata in TIKA-472, i realized
> the current design had some restrictions:
>  * I could not access the typed getters from Metadata Extractor, such
> as getDate (to format iso date) and getStringArray (for keywords).
>  * The handler function was called one field at a time which prevents
> logic where one field depends on the value of another (there is for
> example record versions and fields that specify encoding)
> See attached patch. It refactors TiffExtractor to MetadataExtractorExtractor.
> The patch also includes the date fix, see https://issues.apache.org/jira/browse/TIKA-451#action_12898794
> We can later add more Extractors using other libraries, and map to parsers based on format. For example we already use ImageIO in ImageParser so maybe there should be an ImageIOExtractor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.