You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Noel J. Bergman" <no...@devtech.com> on 2002/10/05 04:05:48 UTC
[PATCH] GenericListserv
The code for normalizing the subject line was seriously broken (for example,
if you had a subject like:
Re: [PREFIX] Re: New subject (was Re: Old Subject)
you'd something like:
[PREFIX] Re:Old Subject
In any event, I've (a) fixed it, and (b) moved it into its own routine, so
that the next person who wants to work on the code can pull it out into a
unit test driver. While I was at it, I rewrote the code to use StringBuffer
editing instead of String manipulation.
--- Noel
RE: [PATCH] GenericListserv
Posted by "Noel J. Bergman" <no...@devtech.com>.
Danny,
What specifically are you refering to? This change DOES remove all but one
Re:. The example I gave was one where the old code didn't just remove the
duplicate Re:, but it stripped out real subject content.
Attached is a test driver. If you spot any examples whose behavior you
don't like, point them out and I'll adjust them.
--- Noel
-----Original Message-----
From: Danny Angus [mailto:danny@apache.org]
Sent: Saturday, October 05, 2002 7:32
To: James Developers List
Subject: RE: [PATCH] GenericListserv
-1 to this change, that was deliberate behaviour.
Your mail client will prepend another "Re: ", the listserve removes it.
d.
> -----Original Message-----
> From: Noel J. Bergman [mailto:noel@devtech.com]
> Sent: 05 October 2002 03:06
> To: James-Dev Mailing List
> Subject: [PATCH] GenericListserv
>
>
> The code for normalizing the subject line was seriously broken
> (for example, if you had a subject like:
>
> Re: [PREFIX] Re: New subject (was Re: Old Subject)
>
> you'd something like:
>
> [PREFIX] Re:Old Subject
>
> In any event, I've (a) fixed it, and (b) moved it into its own routine, so
> that the next person who wants to work on the code can pull it out into a
> unit test driver. While I was at it, I rewrote the code to use
> StringBuffer editing instead of String manipulation.
>
> --- Noel
RE: [PATCH] GenericListserv
Posted by Danny Angus <da...@apache.org>.
-1 to this change, that was deliberate behaviour.
Your mail client will prepend another "Re: ", the listserve removes it.
d.
> -----Original Message-----
> From: Noel J. Bergman [mailto:noel@devtech.com]
> Sent: 05 October 2002 03:06
> To: James-Dev Mailing List
> Subject: [PATCH] GenericListserv
>
>
> The code for normalizing the subject line was seriously broken
> (for example,
> if you had a subject like:
>
> Re: [PREFIX] Re: New subject (was Re: Old Subject)
>
> you'd something like:
>
> [PREFIX] Re:Old Subject
>
> In any event, I've (a) fixed it, and (b) moved it into its own routine, so
> that the next person who wants to work on the code can pull it out into a
> unit test driver. While I was at it, I rewrote the code to use
> StringBuffer
> editing instead of String manipulation.
>
> --- Noel
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>