You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2023/08/19 13:53:52 UTC

[GitHub] [hudi] voonhous opened a new pull request, #9457: [MINOR] Close record readers after use during tests

voonhous opened a new pull request, #9457:
URL: https://github.com/apache/hudi/pull/9457

   ### Change Logs
   
   RecordReader is not being closed in tests. If tests are being executed in images with low limits on file descriptors and allowed files, test may fail.
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   None
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   None
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [X] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #9457: [MINOR] Close record readerds after use during tests

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9457:
URL: https://github.com/apache/hudi/pull/9457#issuecomment-1680437477

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d423d2b7a5e79e314863e5e56528168b15d43ab8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d423d2b7a5e79e314863e5e56528168b15d43ab8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d423d2b7a5e79e314863e5e56528168b15d43ab8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #9457: [MINOR] Close record readerds after use during tests

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9457:
URL: https://github.com/apache/hudi/pull/9457#issuecomment-1680499835

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d423d2b7a5e79e314863e5e56528168b15d43ab8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19322",
       "triggerID" : "d423d2b7a5e79e314863e5e56528168b15d43ab8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d423d2b7a5e79e314863e5e56528168b15d43ab8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19322) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #9457: [MINOR] Close record readers after use during tests

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #9457:
URL: https://github.com/apache/hudi/pull/9457


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan closed pull request #9457: [MINOR] Close record readers after use during tests

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan closed pull request #9457: [MINOR] Close record readers after use during tests
URL: https://github.com/apache/hudi/pull/9457


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #9457: [MINOR] Close record readers after use during tests

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9457:
URL: https://github.com/apache/hudi/pull/9457#issuecomment-1680698404

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d423d2b7a5e79e314863e5e56528168b15d43ab8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19322",
       "triggerID" : "d423d2b7a5e79e314863e5e56528168b15d43ab8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d423d2b7a5e79e314863e5e56528168b15d43ab8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=19322) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #9457: [MINOR] Close record readers after use during tests

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #9457:
URL: https://github.com/apache/hudi/pull/9457#issuecomment-1684948315

   test failure is unrelated. Landing the patch. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org