You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "DanielWang2035 (via GitHub)" <gi...@apache.org> on 2024/10/30 08:44:46 UTC
[PR] Load: create DB in lower-case & truncate null suffix of device ID [iotdb]
DanielWang2035 opened a new pull request, #13966:
URL: https://github.com/apache/iotdb/pull/13966
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Load: create DB in lower-case & truncate null suffix of device ID [iotdb]
Posted by "luoluoyuyu (via GitHub)" <gi...@apache.org>.
luoluoyuyu commented on code in PR #13966:
URL: https://github.com/apache/iotdb/pull/13966#discussion_r1823674741
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/load/LoadTsFileTableSchemaCache.java:
##########
@@ -226,7 +226,7 @@ public List<Object[]> getDeviceIdList() {
final int realColumnIndex = fileColumn2RealColumn.getValue();
deviceIdArray[realColumnIndex] = device.getSegments()[fileColumnIndex + 1];
}
Review Comment:
`device.getSegments()[fileColumnIndex + 1]` will cause array out of bounds. If a table is defined with an id, when the id of a row is null, the length of `device.getSegments()` is 1 and the content is only [table], and the null value will not be saved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Load: create DB in lower-case & truncate null suffix of device ID [iotdb]
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #13966:
URL: https://github.com/apache/iotdb/pull/13966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org