[GitHub] chetanmeh commented on a change in pull request #3579: Using non root user in controller

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #3579: Using non root user in controller
URL: https://github.com/apache/incubator-openwhisk/pull/3579#discussion_r195973173
 
 

 ##########
 File path: core/controller/Dockerfile
 ##########
 @@ -16,19 +16,25 @@
 
 FROM scala
 
+ENV UID=1001 \
+    NOT_ROOT_USER=owuser
+
 # Install swagger-ui
 RUN curl -sSL -o swagger-ui-v3.6.0.tar.gz --no-verbose https://github.com/swagger-api/swagger-ui/archive/v3.6.0.tar.gz && \
     mkdir swagger-ui && \
     tar zxf swagger-ui-v3.6.0.tar.gz -C /swagger-ui --strip-components=2 swagger-ui-3.6.0/dist && \
     rm swagger-ui-v3.6.0.tar.gz && \
     sed -i s#http://petstore.swagger.io/v2/swagger.json#/api/v1/api-docs#g /swagger-ui/index.html
 
-#
 # Copy app jars
 ADD build/distributions/controller.tar /
 
 COPY init.sh /
 RUN chmod +x init.sh
+RUN chmod 777 /root
 
 Review comment:
   Can this be more restrictive? Which part requires the permissions to be open up in conntroller

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services