You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/07/20 16:09:00 UTC

[jira] [Work logged] (HIVE-26417) Iceberg integration: disable update and merge iceberg table when split update is off

     [ https://issues.apache.org/jira/browse/HIVE-26417?focusedWorklogId=793327&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793327 ]

ASF GitHub Bot logged work on HIVE-26417:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Jul/22 16:08
            Start Date: 20/Jul/22 16:08
    Worklog Time Spent: 10m 
      Work Description: kasakrisz opened a new pull request, #3461:
URL: https://github.com/apache/hive/pull/3461

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   1. Separate legacy and split update early version of Update and Merge SemanticAnalyzer into separate classes.
   2. Disable legacy update of iceberg tables. Throw exception.
   3. Remove `HiveIcebergUpdateWriter.java` and `HiveIcebergBufferedDeleteWriter.java`
   
   ### Why are the changes needed?
   Update and Merge of iceberg tables is only supported using split update early feature.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   ```
   mvn test -Dtest.output.overwrite -Dtest=TestIcebergNegativeCliDriver -Dqfile=update_split_update_off.q,merge_split_update_off.q -pl itests/qtest-iceberg -Piceberg -Pitests
   mvn test -Dtest.output.overwrite -Dtest=TestIcebergCliDriver -Dqfile=merge_iceberg_orc.q,merge_iceberg_partitioned_orc.q,update_iceberg_partitioned_orc.q -pl itests/qtest-iceberg -Piceberg -Pitests
   mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=sort_acid.q -pl itests/qtest -Pitests
   ```




Issue Time Tracking
-------------------

            Worklog Id:     (was: 793327)
    Remaining Estimate: 0h
            Time Spent: 10m

> Iceberg integration: disable update and merge iceberg table when split update is off
> ------------------------------------------------------------------------------------
>
>                 Key: HIVE-26417
>                 URL: https://issues.apache.org/jira/browse/HIVE-26417
>             Project: Hive
>          Issue Type: Improvement
>          Components: File Formats
>            Reporter: Krisztian Kasa
>            Assignee: Krisztian Kasa
>            Priority: Major
>             Fix For: 4.0.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Iceberg table update and merge is implemented using split update early by HIVE-26319 and HIVE-26385.
> Without split update early deleted records has to be buffered in memory  when updating iceberg tables. With split update early deleted records are processed by a separate reducer and no buffering is required. The ReduceSink operator also sorts the records.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)