You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2016/10/22 00:08:39 UTC
[Impala-ASF-CR] IMPALA-4342: Use sync ddl=1 for test udf errors
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4792
Change subject: IMPALA-4342: Use sync_ddl=1 for test_udf_errors
......................................................................
IMPALA-4342: Use sync_ddl=1 for test_udf_errors
Make sure changes by DDL statements are propagated to all
Impala nodes in the cluster. This avoids spurious test failures
due to failed DDL statements as a result of stale metadata.
Change-Id: I9063e9c80833904d26dd06e694bc3158a04acee2
---
M tests/query_test/test_udfs.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/4792/1
--
To view, visit http://gerrit.cloudera.org:8080/4792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9063e9c80833904d26dd06e694bc3158a04acee2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-4342: Use sync ddl=1 for test udf errors
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4342: Use sync_ddl=1 for test_udf_errors
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4792/1/tests/query_test/test_udfs.py
File tests/query_test/test_udfs.py:
Line 83: self.run_test_case('QueryTest/udf-errors', vector)
we run all queries in this test with the same client, why do we need sync_ddl then?
--
To view, visit http://gerrit.cloudera.org:8080/4792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9063e9c80833904d26dd06e694bc3158a04acee2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4342: Use sync ddl=1 for test udf errors
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has abandoned this change.
Change subject: IMPALA-4342: Use sync_ddl=1 for test_udf_errors
......................................................................
Abandoned
Does not seem like the right fix. The underlying issue looks like http://issues.cloudera.org/browse/IMPALA-3888
--
To view, visit http://gerrit.cloudera.org:8080/4792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I9063e9c80833904d26dd06e694bc3158a04acee2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-4342: Use sync ddl=1 for test udf errors
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4342: Use sync_ddl=1 for test_udf_errors
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4792/1/tests/query_test/test_udfs.py
File tests/query_test/test_udfs.py:
Line 83: self.run_test_case('QueryTest/udf-errors', vector)
> Does it mean that the 2 DDL statements will go to the same coordinator with
Yes. As discussed, this looks like a product bug similar to IMPALA-3888.
--
To view, visit http://gerrit.cloudera.org:8080/4792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9063e9c80833904d26dd06e694bc3158a04acee2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4342: Use sync ddl=1 for test udf errors
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-4342: Use sync_ddl=1 for test_udf_errors
......................................................................
Patch Set 1:
we hit this again. can you please update the Jira with the content of your discussion? Thanks, Lars
--
To view, visit http://gerrit.cloudera.org:8080/4792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9063e9c80833904d26dd06e694bc3158a04acee2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4342: Use sync ddl=1 for test udf errors
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: IMPALA-4342: Use sync_ddl=1 for test_udf_errors
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4792/1/tests/query_test/test_udfs.py
File tests/query_test/test_udfs.py:
Line 83: self.run_test_case('QueryTest/udf-errors', vector)
> we run all queries in this test with the same client, why do we need sync_d
Does it mean that the 2 DDL statements will go to the same coordinator with 100% certainty ? If so, I am confused as to how IMPALA-3888 and this JIRA can happen then.
--
To view, visit http://gerrit.cloudera.org:8080/4792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9063e9c80833904d26dd06e694bc3158a04acee2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: Yes